[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH v2 9/9] iotests: Unify log outputs between Pytho
From: |
Cleber Rosa |
Subject: |
Re: [Qemu-block] [PATCH v2 9/9] iotests: Unify log outputs between Python 2 and 3 |
Date: |
Fri, 19 Oct 2018 20:59:49 -0400 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.0 |
On 10/19/18 3:15 PM, Max Reitz wrote:
> When dumping an object into the log, there are differences between
> Python 2 and 3. First, unicode strings are prefixed by 'u' in Python 2
> (they are no longer in 3, because unicode strings are the default
> there). Second, the order of keys in dicts may differ. Third,
> especially long numbers are longs in Python 2 and thus get an 'L'
> suffix, which does not happen in Python 3.
>
> We can get around all of these differences by dumping objects (lists and
> dicts) in a language-independent format, namely JSON. The JSON
> generator even allows emitting dicts with their keys sorted
> alphabetically.
>
> This changes the output of all tests that use these logging functions
> (dict keys are ordered now, strings in dicts are now enclosed in double
> quotes instead of single quotes, the 'L' suffix of large integers is
> dropped, and "true" and "false" are now in lower case).
> The quote change necessitates a small change to a filter used in test
> 207.
>
> Suggested-by: Eduardo Habkost <address@hidden>
> Signed-off-by: Max Reitz <address@hidden>
Reviewed-by: Cleber Rosa <address@hidden>
- [Qemu-block] [PATCH v2 8/9] iotests: Modify imports for Python 3, (continued)
- [Qemu-block] [PATCH v2 8/9] iotests: Modify imports for Python 3, Max Reitz, 2018/10/19
- [Qemu-block] [PATCH v2 5/9] iotests: Different iterator behavior in Python 3, Max Reitz, 2018/10/19
- [Qemu-block] [PATCH v2 6/9] iotests: Explicitly inherit FDs in Python, Max Reitz, 2018/10/19
- [Qemu-block] [PATCH v2 9/9] iotests: Unify log outputs between Python 2 and 3, Max Reitz, 2018/10/19
- Re: [Qemu-block] [PATCH v2 9/9] iotests: Unify log outputs between Python 2 and 3,
Cleber Rosa <=
- Re: [Qemu-block] [PATCH v2 0/9] iotests: Make them work for both Python 2 and 3, Cleber Rosa, 2018/10/19