[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-block] [PATCH v4 09/11] iscsi: Support auto-read-only option
From: |
Kevin Wolf |
Subject: |
[Qemu-block] [PATCH v4 09/11] iscsi: Support auto-read-only option |
Date: |
Fri, 19 Oct 2018 18:30:13 +0200 |
If read-only=off, but auto-read-only=on is given, open the volume
read-write if we have the permissions, but instead of erroring out for
read-only volumes, just degrade to read-only.
Signed-off-by: Kevin Wolf <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
---
block/iscsi.c | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/block/iscsi.c b/block/iscsi.c
index bb69faf34a..130ae26f5f 100644
--- a/block/iscsi.c
+++ b/block/iscsi.c
@@ -1878,9 +1878,11 @@ static int iscsi_open(BlockDriverState *bs, QDict
*options, int flags,
/* Check the write protect flag of the LUN if we want to write */
if (iscsilun->type == TYPE_DISK && (flags & BDRV_O_RDWR) &&
iscsilun->write_protected) {
- error_setg(errp, "Cannot open a write protected LUN as read-write");
- ret = -EACCES;
- goto out;
+ ret = bdrv_apply_auto_read_only(bs, "LUN is write protected", errp);
+ if (ret < 0) {
+ goto out;
+ }
+ flags &= ~BDRV_O_RDWR;
}
iscsi_readcapacity_sync(iscsilun, &local_err);
--
2.19.1
- [Qemu-block] [PATCH v4 01/11] block: Update flags in bdrv_set_read_only(), (continued)
- [Qemu-block] [PATCH v4 01/11] block: Update flags in bdrv_set_read_only(), Kevin Wolf, 2018/10/19
- [Qemu-block] [PATCH v4 02/11] block: Add auto-read-only option, Kevin Wolf, 2018/10/19
- [Qemu-block] [PATCH v4 04/11] block: Require auto-read-only for existing fallbacks, Kevin Wolf, 2018/10/19
- [Qemu-block] [PATCH v4 07/11] curl: Support auto-read-only option, Kevin Wolf, 2018/10/19
- [Qemu-block] [PATCH v4 06/11] file-posix: Support auto-read-only option, Kevin Wolf, 2018/10/19
- [Qemu-block] [PATCH v4 08/11] gluster: Support auto-read-only option, Kevin Wolf, 2018/10/19
- [Qemu-block] [PATCH v4 05/11] nbd: Support auto-read-only option, Kevin Wolf, 2018/10/19
- [Qemu-block] [PATCH v4 03/11] rbd: Close image in qemu_rbd_open() error path, Kevin Wolf, 2018/10/19
- [Qemu-block] [PATCH v4 09/11] iscsi: Support auto-read-only option,
Kevin Wolf <=
- [Qemu-block] [PATCH v4 10/11] block: Make auto-read-only=on default for -drive, Kevin Wolf, 2018/10/20
- [Qemu-block] [PATCH v4 11/11] qemu-iotests: Test auto-read-only with -drive and -blockdev, Kevin Wolf, 2018/10/20
- Re: [Qemu-block] [PATCH v4 00/11] block: Add auto-read-only option, Kevin Wolf, 2018/10/31