[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH 1/2] qemu-nbd: drop old-style negotiation
From: |
Eric Blake |
Subject: |
Re: [Qemu-block] [PATCH 1/2] qemu-nbd: drop old-style negotiation |
Date: |
Wed, 3 Oct 2018 12:31:11 -0500 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.0 |
On 10/3/18 12:02 PM, Vladimir Sementsov-Ogievskiy wrote:
Use new-style negotiation always, with default "" (empty) export name
if it is not specified with '-x' option.
If we like this approach (over mine of keeping oldstyle, but via an
explicit -O option), then this commit message should add the following:
qemu as client can manage either style since 2.6.0, commit 69b49502d8
For comparison:
nbdkit 1.3 switched its default to newstyle (Jan 2018):
https://github.com/libguestfs/nbdkit/commit/b2a8aecc
https://github.com/libguestfs/nbdkit/commit/8158e773
nbd 3.10 dropped oldstyle long ago (Mar 2015):
https://github.com/NetworkBlockDevice/nbd/commit/36940193
Signed-off-by: Vladimir Sementsov-Ogievskiy <address@hidden>
---
qemu-nbd.c | 25 ++++++-------------------
1 file changed, 6 insertions(+), 19 deletions(-)
If we like your patch over mine,
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
Re: [Qemu-block] [PATCH 0/2] nbd server: drop old-style negotiation, Eric Blake, 2018/10/03