[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 2/4] tests/avocado: drop virtio-rng from sbsa-ref tests
From: |
Peter Maydell |
Subject: |
Re: [PATCH v2 2/4] tests/avocado: drop virtio-rng from sbsa-ref tests |
Date: |
Thu, 14 Mar 2024 12:14:03 +0000 |
On Thu, 14 Mar 2024 at 12:11, Alex Bennée <alex.bennee@linaro.org> wrote:
>
> Marcin Juszkiewicz <marcin.juszkiewicz@linaro.org> writes:
>
> > sbsa-ref is supposed to emulate real hardware so virtio-rng-pci
> > does not fit here
>
> What is real anyway ;-)
>
> VirtIO devices exist in real life and I would argue for PCI the device
> appears very much like a normal PCI device. I could see the argument for
> avoiding virtio-mmio devices which are a lot more VM-only in flavour.
But our platform for testing virtio-rng-pci should be the 'virt'
board (and our avocado test for virt does indeed have that device).
What exactly are we adding by testing it also in sbsa-ref,
where the typical user will *not* be using it (if they wanted
a virtio setup they would be using 'virt')?
thanks
-- PMM