RE: [PATCH v1 8/8] aspeed: Add an AST2700 eval board

[Jamin Lin]

> -----Original Message-----
> From: Jamin Lin <jamin_lin@aspeedtech.com>
> Sent: Thursday, February 29, 2024 3:43 PM
> To: clg@kaod.org; peter.maydell@linaro.org; andrew@codeconstruct.com.au;
> joel@jms.id.au; qemu-arm@nongnu.org; qemu-devel@nongnu.org
> Cc: Troy Lee <troy_lee@aspeedtech.com>; Jamin Lin
> <jamin_lin@aspeedtech.com>; Yunlin Tang <yunlin.tang@aspeedtech.com>
> Subject: [PATCH v1 8/8] aspeed: Add an AST2700 eval board
> 
Hi all,

I tried to send the patch series to support AST2700 but I encountered some 
patches
were rejected by server IP 211.20.114.70.

Error Log:
qemu-devel@nongnu.org
eggs.gnu.org
Remote Server returned '550-[SPF] 211.20.114.70 is not allowed to send mail 
from aspeedtech.com. 550 Please see 
http://www.openspf.org/Why?scope=mfrom;identity=jamin_lin@aspeedtech.com;ip=211.20.114.70'
qemu-arm@nongnu.org
eggs.gnu.org
Remote Server returned '550-[SPF] 211.20.114.70 is not allowed to send mail 
from aspeedtech.com. 550 Please see 
http://www.openspf.org/Why?scope=mfrom;identity=jamin_lin@aspeedtech.com;ip=211.20.114.70

Did you encounter the same errors before?
My send email command as following.
git send-email 
--cc troy_lee@aspeedtech.com 
--cc jamin_lin@aspeedtech.com 
--cc yunlin.tang@aspeedtech.com 
--to-cmd "./scripts/get_maintainer.pl ../v1-patch/*.patch" ../v1-patch/*.patch

Thanks-Jamin

> AST2700 CPU is ARM Cortex-A35 which is 64 bits.
> Add TARGET_AARCH64 to build this machine.
> 
> According to the design of ast2700, it has a bootmcu(riscv-32) which is used
> for executing SPL.
> Then, CPUs(cortex-a35) execute u-boot, kernel and rofs.
> 
> Currently, qemu not support emulate two CPU architectures at the same
> machine. Therefore, qemu will only support to emulate CPU(cortex-a35) side
> for ast2700
> 
> Signed-off-by: Troy Lee <troy_lee@aspeedtech.com>
> Signed-off-by: Jamin Lin <jamin_lin@aspeedtech.com>
> ---
>  hw/arm/aspeed.c | 32 ++++++++++++++++++++++++++++++++
>  1 file changed, 32 insertions(+)
> 
> diff --git a/hw/arm/aspeed.c b/hw/arm/aspeed.c index
> 8854581ca8..4544026d14 100644
> --- a/hw/arm/aspeed.c
> +++ b/hw/arm/aspeed.c
> @@ -178,6 +178,12 @@ struct AspeedMachineState {  #define
> AST2600_EVB_HW_STRAP1 0x000000C0  #define AST2600_EVB_HW_STRAP2
> 0x00000003
> 
> +#ifdef TARGET_AARCH64
> +/* AST2700 evb hardware value */
> +#define AST2700_EVB_HW_STRAP1 0x000000C0 #define
> AST2700_EVB_HW_STRAP2
> +0x00000003 #endif
> +
>  /* Tacoma hardware value */
>  #define TACOMA_BMC_HW_STRAP1  0x00000000  #define
> TACOMA_BMC_HW_STRAP2  0x00000040 @@ -1588,6 +1594,26 @@ static
> void aspeed_minibmc_machine_ast1030_evb_class_init(ObjectClass *oc,
>      aspeed_machine_class_init_cpus_defaults(mc);
>  }
> 
> +#ifdef TARGET_AARCH64
> +static void aspeed_machine_ast2700_evb_class_init(ObjectClass *oc, void
> +*data) {
> +    MachineClass *mc = MACHINE_CLASS(oc);
> +    AspeedMachineClass *amc = ASPEED_MACHINE_CLASS(oc);
> +
> +    mc->desc = "Aspeed AST2700 EVB (Cortex-A35)";
> +    amc->soc_name  = "ast2700-a0";
> +    amc->hw_strap1 = AST2700_EVB_HW_STRAP1;
> +    amc->hw_strap2 = AST2700_EVB_HW_STRAP2;
> +    amc->fmc_model = "w25q01jvq";
> +    amc->spi_model = "w25q512jv";
> +    amc->num_cs    = 2;
> +    amc->macs_mask = ASPEED_MAC0_ON | ASPEED_MAC1_ON |
> ASPEED_MAC2_ON;
> +    amc->uart_default = ASPEED_DEV_UART12;
> +    mc->default_ram_size = 1 * GiB;
> +    aspeed_machine_class_init_cpus_defaults(mc);
> +}
> +#endif
> +
>  static void aspeed_machine_qcom_dc_scm_v1_class_init(ObjectClass *oc,
>                                                       void *data)
> { @@ -1711,6 +1737,12 @@ static const TypeInfo aspeed_machine_types[] = {
>          .name           = MACHINE_TYPE_NAME("ast1030-evb"),
>          .parent         = TYPE_ASPEED_MACHINE,
>          .class_init     =
> aspeed_minibmc_machine_ast1030_evb_class_init,
> +#ifdef TARGET_AARCH64
> +    }, {
> +        .name          = MACHINE_TYPE_NAME("ast2700-evb"),
> +        .parent        = TYPE_ASPEED_MACHINE,
> +        .class_init    = aspeed_machine_ast2700_evb_class_init,
> +#endif
>      }, {
>          .name          = TYPE_ASPEED_MACHINE,
>          .parent        = TYPE_MACHINE,
> --
> 2.25.1