[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [RFC 4/8] hw/core: Add cache topology options in -smp
From: |
Zhao Liu |
Subject: |
Re: [RFC 4/8] hw/core: Add cache topology options in -smp |
Date: |
Tue, 27 Feb 2024 18:35:36 +0800 |
> > > > + if (smp_cache_string_to_topology(ms, config->l1d_cache,
> > > > + &ms->smp_cache.l1d, errp)) {
> > >
> > > Indent is to wrong opening bracket.
> > > Same for other cases.
> >
> > Could you please educate me about the correct style here?
> > I'm unsure if it should be indented by 4 spaces.
>
> It needs to look like this:
>
> if (smp_cache_string_to_topology(ms, config->l1d_cache,
> &ms->smp_cache.l1d, errp)) {
>
> so func parameters are aligned to the function calls' opening bracket,
> not the 'if' statement's opening bracket.
>
Thanks for your explaination!
Regards,
Zhao
- [RFC 2/8] hw/core: Move CPU topology enumeration into arch-agnostic file, (continued)
RE: [RFC 4/8] hw/core: Add cache topology options in -smp, JeeHeng Sia, 2024/02/28
[RFC 5/8] i386/cpu: Support thread and module level cache topology, Zhao Liu, 2024/02/20
[RFC 6/8] i386/cpu: Update cache topology with machine's configuration, Zhao Liu, 2024/02/20
[RFC 7/8] i386/pc: Support cache topology in -smp for PC machine, Zhao Liu, 2024/02/20
[RFC 8/8] qemu-options: Add the cache topology description of -smp, Zhao Liu, 2024/02/20