[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v5] arm/kvm: Enable support for KVM_ARM_VCPU_PMU_V3_FILTER
From: |
Eric Auger |
Subject: |
Re: [PATCH v5] arm/kvm: Enable support for KVM_ARM_VCPU_PMU_V3_FILTER |
Date: |
Wed, 17 Jan 2024 17:46:16 +0100 |
User-agent: |
Mozilla Thunderbird |
Hi Sebastian,
On 1/17/24 17:29, Sebastian Ott wrote:
> On Wed, 17 Jan 2024, Eric Auger wrote:
>> On 1/15/24 09:01, Shaoqin Huang wrote:
>>> + /*
>>> + * The filter only needs to be initialized through one vcpu
>>> ioctl and it
>>> + * will affect all other vcpu in the vm.
>>> + */
>>> + if (pmu_filter_init) {
>> I think I commented on that on the v4. Maybe I missed your reply. You
>> sure you don't need to call it for each vcpu?
>
> From (kernel) commit d7eec2360e3 ("KVM: arm64: Add PMU event filtering
> infrastructure"):
> Note that although the ioctl is per-vcpu, the map of allowed events is
> global to the VM (it can be setup from any vcpu until the vcpu PMU is
> initialized).
Ah OK. I forgot that specificity.
Thanks!
Eric
>
> Sebastian
>