Re: [PATCH v8 00/10] Introduce model for IBM's FSI

[Ninad Palsule]

Hello Cedric,


> >   include/hw/fsi/aspeed-apb2opb.h |  34 ++++
>
> aspeed-apb2opb is a HW logic bridging the FSI world and Aspeed. It
> doesn't belong to the FSI susbsytem. Since we don't have a directory
> for platform specific devices, I think the model shoud go under hw/misc/.
Moved it to hw/misc directory
> >   include/hw/fsi/cfam.h           |  45 +++++
>
> scratchpad is the only lbus device and it is quite generic, we could
> move it to lbus files. It would be nice to implement more than one
> reg.
Moved scratchpad to lbus files.
> >   include/hw/fsi/fsi-master.h     |  32 ++++
> >   include/hw/fsi/fsi-slave.h      |  29 +++
> >   include/hw/fsi/fsi.h            |  24 +++
>
> I would move the definitions and implementation of the fsi bus and
> the fsi slave under the fsi.h and fsi.c files
Moved fsi-slave to fsi files.
> >   include/hw/fsi/lbus.h           |  40 ++++
> >   include/hw/fsi/opb.h            |  25 +++
>
> opb is quite minimal now and I think it could be hidden under
> aspeed-apb2opb.
Moved opb to aspeed-apb2opb files.
> >   hw/fsi/Kconfig                  |  21 +++
>
> one CONFIG_FSI option and one CONFIG_FSI_APB2OPB should be enough.
> CONFIG_FSI_APB2OPB should select FSI and depends on CONFIG_ASPEED_SOC.
Reduced number of configs as you suggested.

Thanks for the review.

Regards,

Ninad