[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[RFC PATCH 4/5] hw/arm/armv7m: Error if trying to set unavailable ARMCPU
From: |
Philippe Mathieu-Daudé |
Subject: |
[RFC PATCH 4/5] hw/arm/armv7m: Error if trying to set unavailable ARMCPU::vfp property |
Date: |
Tue, 2 Jan 2024 17:04:53 +0100 |
Do not ignore impossible configuration requested by the user.
For example, when trying to enable VFP on a Cortex-M33 we now get:
qemu-system-arm: 'cortex-m33-arm-cpu' does not support VFP
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
hw/arm/armv7m.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/hw/arm/armv7m.c b/hw/arm/armv7m.c
index 3610f6f4a1..12cdad09f9 100644
--- a/hw/arm/armv7m.c
+++ b/hw/arm/armv7m.c
@@ -328,6 +328,9 @@ static void armv7m_realize(DeviceState *dev, Error **errp)
if (!object_property_set_bool(OBJECT(s->cpu), "vfp", s->vfp, errp)) {
return;
}
+ } else if (s->vfp == OPTIONAL_BOOL_TRUE) {
+ error_setg(errp, "'%s' does not support VFP", s->cpu_type);
+ return;
}
if (object_property_find(OBJECT(s->cpu), "dsp")) {
if (!object_property_set_bool(OBJECT(s->cpu), "dsp", s->dsp, errp)) {
--
2.41.0
- [RFC PATCH 0/5] qdev-properties: Try to improve use of dynamic property introspection, Philippe Mathieu-Daudé, 2024/01/02
- [RFC PATCH 3/5] hw/arm/armv7m: Convert ARMv7MState::vfp from bool to OptionalBool, Philippe Mathieu-Daudé, 2024/01/02
- [RFC PATCH 2/5] qdev-properties: Add OptionalBool QAPI type, Philippe Mathieu-Daudé, 2024/01/02
- [RFC PATCH 1/5] qdev-properties: Add qdev_property_del_static(), Philippe Mathieu-Daudé, 2024/01/02
- [RFC PATCH 4/5] hw/arm/armv7m: Error if trying to set unavailable ARMCPU::vfp property,
Philippe Mathieu-Daudé <=
- [RFC PATCH 5/5] hw/arm/armv7m: Do not expose 'vfp' property if ARM CPU doesn't have it, Philippe Mathieu-Daudé, 2024/01/02
- Re: [RFC PATCH 0/5] qdev-properties: Try to improve use of dynamic property introspection, Kevin Wolf, 2024/01/09