[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v3 1/9] hw/sd/pxa2xx: Realize sysbus device before accessing it
From: |
Philippe Mathieu-Daudé |
Subject: |
[PATCH v3 1/9] hw/sd/pxa2xx: Realize sysbus device before accessing it |
Date: |
Fri, 20 Oct 2023 15:03:22 +0200 |
sysbus_mmio_map() and sysbus_connect_irq() should not be
called on unrealized device.
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Thomas Huth <thuth@redhat.com>
---
hw/sd/pxa2xx_mmci.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/sd/pxa2xx_mmci.c b/hw/sd/pxa2xx_mmci.c
index 124fbf8bbd..9f7a880bac 100644
--- a/hw/sd/pxa2xx_mmci.c
+++ b/hw/sd/pxa2xx_mmci.c
@@ -483,11 +483,11 @@ PXA2xxMMCIState *pxa2xx_mmci_init(MemoryRegion *sysmem,
dev = qdev_new(TYPE_PXA2XX_MMCI);
sbd = SYS_BUS_DEVICE(dev);
+ sysbus_realize_and_unref(sbd, &error_fatal);
sysbus_mmio_map(sbd, 0, base);
sysbus_connect_irq(sbd, 0, irq);
qdev_connect_gpio_out_named(dev, "rx-dma", 0, rx_dma);
qdev_connect_gpio_out_named(dev, "tx-dma", 0, tx_dma);
- sysbus_realize_and_unref(sbd, &error_fatal);
return PXA2XX_MMCI(dev);
}
--
2.41.0
- [PATCH v3 0/9] hw/arm/pxa2xx: SysBus/QDev fixes, Philippe Mathieu-Daudé, 2023/10/20
- [PATCH v3 1/9] hw/sd/pxa2xx: Realize sysbus device before accessing it,
Philippe Mathieu-Daudé <=
- [PATCH v3 2/9] hw/sd/pxa2xx: Do not open-code sysbus_create_simple(), Philippe Mathieu-Daudé, 2023/10/20
- [PATCH v3 3/9] hw/pcmcia/pxa2xx: Realize sysbus device before accessing it, Philippe Mathieu-Daudé, 2023/10/20
- [PATCH v3 4/9] hw/pcmcia/pxa2xx: Do not open-code sysbus_create_simple(), Philippe Mathieu-Daudé, 2023/10/20
- [PATCH v3 6/9] hw/intc/pxa2xx: Convert to Resettable interface, Philippe Mathieu-Daudé, 2023/10/20
- [PATCH v3 7/9] hw/intc/pxa2xx: Pass CPU reference using QOM link property, Philippe Mathieu-Daudé, 2023/10/20
- [PATCH v3 5/9] hw/pcmcia/pxa2xx: Inline pxa2xx_pcmcia_init(), Philippe Mathieu-Daudé, 2023/10/20
- [PATCH v3 8/9] hw/intc/pxa2xx: Factor pxa2xx_pic_realize() out of pxa2xx_pic_init(), Philippe Mathieu-Daudé, 2023/10/20
- [PATCH v3 9/9] hw/arm/pxa2xx: Realize PXA2XX_I2C device before accessing it, Philippe Mathieu-Daudé, 2023/10/20