[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 4/9] microbit: add missing qtest_quit() call
From: |
Alex Bennée |
Subject: |
[PATCH 4/9] microbit: add missing qtest_quit() call |
Date: |
Thu, 14 Sep 2023 16:54:17 +0100 |
From: Daniel P. Berrangé <berrange@redhat.com>
Without this call, the QEMU process is being left running which on
FreeBSD 13.2 at least, makes meson think the test is still running,
and thus execution of "make check" continues forever.
This fixes the regression introduced in:
commit a9c9bbee855877293683012942d3485d50f286af
Author: Chris Laplante <chris@laplante.io>
Date: Tue Aug 22 17:31:02 2023 +0100
qtest: microbit-test: add tests for nRF51 DETECT
Fixes: https://gitlab.com/qemu-project/qemu/-/issues/1882
Signed-off-by: "Daniel P. Berrangé" <berrange@redhat.com>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Message-Id: <20230912184130.3056054-2-berrange@redhat.com>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
---
tests/qtest/microbit-test.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/tests/qtest/microbit-test.c b/tests/qtest/microbit-test.c
index 2abcad8e31..72190d38f7 100644
--- a/tests/qtest/microbit-test.c
+++ b/tests/qtest/microbit-test.c
@@ -434,6 +434,8 @@ static void test_nrf51_gpio_detect(void)
g_assert_true(qtest_get_irq(qts, 0));
qtest_set_irq_in(qts, "/machine/nrf51", "unnamed-gpio-in", 3, 0);
g_assert_true(qtest_get_irq(qts, 0));
+
+ qtest_quit(qts);
}
static void timer_task(QTestState *qts, hwaddr task)
--
2.39.2
- Re: [PATCH 2/9] gitlab: fix typo/spelling in comments, (continued)
[PATCH 4/9] microbit: add missing qtest_quit() call,
Alex Bennée <=
[PATCH 5/9] qtest: kill orphaned qtest QEMU processes on FreeBSD, Alex Bennée, 2023/09/14
[PATCH 8/9] tests/avocado: Fix console data loss, Alex Bennée, 2023/09/14