[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] hw/intc/arm_gicv3: Simplify gicv3_class_name() logic
|
From: |
Francisco Iglesias |
|
Subject: |
Re: [PATCH] hw/intc/arm_gicv3: Simplify gicv3_class_name() logic |
|
Date: |
Wed, 6 Sep 2023 10:40:58 +0200 |
|
User-agent: |
Mutt/1.10.1 (2018-07-13) |
On [2023 Sep 05] Tue 16:56:51, Philippe Mathieu-Daudé wrote:
> Simplify gicv3_class_name() logic. No functional change intended.
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Francisco Iglesias <frasse.iglesias@gmail.com>
> ---
> hw/intc/arm_gicv3_common.c | 9 ++++-----
> 1 file changed, 4 insertions(+), 5 deletions(-)
>
> diff --git a/hw/intc/arm_gicv3_common.c b/hw/intc/arm_gicv3_common.c
> index 2ebf880ead..8863f06b67 100644
> --- a/hw/intc/arm_gicv3_common.c
> +++ b/hw/intc/arm_gicv3_common.c
> @@ -612,13 +612,12 @@ type_init(register_types)
>
> const char *gicv3_class_name(void)
> {
> - if (kvm_irqchip_in_kernel()) {
> - return "kvm-arm-gicv3";
> - } else {
> - if (kvm_enabled()) {
> + if (kvm_enabled()) {
> + if (!kvm_irqchip_in_kernel()) {
> error_report("Userspace GICv3 is not supported with KVM");
> exit(1);
> }
> - return "arm-gicv3";
> + return "kvm-arm-gicv3";
> }
> + return "arm-gicv3";
> }
> --
> 2.41.0
>
>