[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v4 06/38] qemu-keymap: properly check return from xkb_keymap_mod_
From: |
Alex Bennée |
Subject: |
[PATCH v4 06/38] qemu-keymap: properly check return from xkb_keymap_mod_get_index |
Date: |
Fri, 30 Jun 2023 19:03:51 +0100 |
We can return XKB_MOD_INVALID for AltGr which rightly gets flagged by
sanitisers as an overly wide shift attempt. Properly check the return
type and leave the bitmap as zero in that case. Tested output before
and after is unchanged with the gb and ara keymaps.
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Reviewed-by: Juan Quintela <quintela@redhat.com>
---
qemu-keymap.c | 24 ++++++++++++++++--------
1 file changed, 16 insertions(+), 8 deletions(-)
diff --git a/qemu-keymap.c b/qemu-keymap.c
index 229866e004..8c80f7a4ed 100644
--- a/qemu-keymap.c
+++ b/qemu-keymap.c
@@ -140,6 +140,18 @@ static void usage(FILE *out)
names.options ?: "-");
}
+static xkb_mod_mask_t get_mod(struct xkb_keymap *map, const char *name)
+{
+ xkb_mod_index_t mod;
+ xkb_mod_mask_t mask = 0;
+
+ mod = xkb_keymap_mod_get_index(map, name);
+ if (mod != XKB_MOD_INVALID) {
+ mask = (1 << mod);
+ }
+ return mask;
+}
+
int main(int argc, char *argv[])
{
struct xkb_context *ctx;
@@ -215,14 +227,10 @@ int main(int argc, char *argv[])
mod, xkb_keymap_mod_get_name(map, mod));
}
- mod = xkb_keymap_mod_get_index(map, "Shift");
- shift = (1 << mod);
- mod = xkb_keymap_mod_get_index(map, "Control");
- ctrl = (1 << mod);
- mod = xkb_keymap_mod_get_index(map, "AltGr");
- altgr = (1 << mod);
- mod = xkb_keymap_mod_get_index(map, "NumLock");
- numlock = (1 << mod);
+ shift = get_mod(map, "Shift");
+ ctrl = get_mod(map, "Control");
+ altgr = get_mod(map, "AltGr");
+ numlock = get_mod(map, "NumLock");
state = xkb_state_new(map);
xkb_keymap_key_for_each(map, walk_map, state);
--
2.39.2
- [PATCH v4 00/38] maintainer omnibus: testing, fuzz, plugins, documentation, gdbstub (pre-PR), Alex Bennée, 2023/06/30
- [PATCH v4 02/38] gitlab: ensure coverage job also publishes meson log, Alex Bennée, 2023/06/30
- [PATCH v4 03/38] gitlab: reduce testing scope of check-gcov, Alex Bennée, 2023/06/30
- [PATCH v4 10/38] Makefile: add lcitool-refresh to UNCHECKED_GOALS, Alex Bennée, 2023/06/30
- [PATCH v4 01/38] gitlab: explicit set artifacts publishing criteria, Alex Bennée, 2023/06/30
- [PATCH v4 04/38] docs/devel: remind developers to run CI container pipeline when updating images, Alex Bennée, 2023/06/30
- [PATCH v4 08/38] tests/qtests: clean-up and fix leak in generic_fuzz, Alex Bennée, 2023/06/30
- [PATCH v4 09/38] tests/docker: add test-fuzz, Alex Bennée, 2023/06/30
- [PATCH v4 05/38] tests/tcg: add mechanism to handle plugin arguments, Alex Bennée, 2023/06/30
- [PATCH v4 06/38] qemu-keymap: properly check return from xkb_keymap_mod_get_index,
Alex Bennée <=
- [PATCH v4 07/38] scripts/oss-fuzz: add a suppression for keymap, Alex Bennée, 2023/06/30
- [PATCH v4 12/38] tests/lcitool: Bump fedora container versions, Alex Bennée, 2023/06/30
- [PATCH v4 11/38] tests/lcitool: update to latest version, Alex Bennée, 2023/06/30
- [PATCH v4 38/38] tests/tcg: Add a test for info proc mappings, Alex Bennée, 2023/06/30
- [PATCH v4 14/38] tests/lcitool: introduce qemu-minimal, Alex Bennée, 2023/06/30
- [PATCH v4 13/38] tests/lcitool: add an explicit gcc-native package, Alex Bennée, 2023/06/30
- [PATCH v4 30/38] gdbstub: clean-up vcont handling to avoid goto, Alex Bennée, 2023/06/30
- [PATCH v4 32/38] linux-user: Add "safe" parameter to do_guest_openat(), Alex Bennée, 2023/06/30
- [PATCH v4 20/38] plugins: fix memory leak while parsing options, Alex Bennée, 2023/06/30
- [PATCH v4 37/38] docs: Document security implications of debugging, Alex Bennée, 2023/06/30