[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v3 04/24] tests: make fp-test less chatty when running from test
From: |
Alex Bennée |
Subject: |
[PATCH v3 04/24] tests: make fp-test less chatty when running from test suite |
Date: |
Tue, 28 Feb 2023 19:06:33 +0000 |
As we like to run tests under CI with V=1 flags the softfloat tests
can add up to a fair amount of extra log lines. With an update to the
testfloat library we can now call fp-test with the -q flag and reduce
the output to a terse one line per function tested.
make check-softfloat V=1 | wc -l
759
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Message-Id: <20230221094558.2864616-6-alex.bennee@linaro.org>
---
tests/fp/fp-test.c | 19 ++++++++++++++-----
tests/fp/berkeley-testfloat-3 | 2 +-
tests/fp/meson.build | 2 +-
3 files changed, 16 insertions(+), 7 deletions(-)
diff --git a/tests/fp/fp-test.c b/tests/fp/fp-test.c
index 35829ad5f7..36b5712cda 100644
--- a/tests/fp/fp-test.c
+++ b/tests/fp/fp-test.c
@@ -106,7 +106,8 @@ static const char commands_string[] =
" -l = thoroughness level (1 (default), 2)\n"
" -r = rounding mode (even (default), zero, down, up, tieaway, odd)\n"
" Set to 'all' to test all rounding modes, if applicable\n"
- " -s = stop when a test fails";
+ " -s = stop when a test fails\n"
+ " -q = minimise noise when testing, just show each function being tested";
static void usage_complete(int argc, char *argv[])
{
@@ -190,9 +191,11 @@ static void do_testfloat(int op, int rmode, bool exact)
ab_f128M_z_bool true_ab_f128M_z_bool;
ab_f128M_z_bool subj_ab_f128M_z_bool;
- fputs(">> Testing ", stderr);
- verCases_writeFunctionName(stderr);
- fputs("\n", stderr);
+ if (verCases_verbosity) {
+ fputs(">> Testing ", stderr);
+ verCases_writeFunctionName(stderr);
+ fputs("\n", stderr);
+ }
if (!is_allowed(op, rmode)) {
not_implemented();
@@ -837,7 +840,7 @@ static void parse_args(int argc, char *argv[])
int c;
for (;;) {
- c = getopt(argc, argv, "he:f:l:r:s");
+ c = getopt(argc, argv, "he:f:l:r:sq");
if (c < 0) {
break;
}
@@ -874,9 +877,15 @@ static void parse_args(int argc, char *argv[])
}
}
break;
+ /*
+ * The following flags are declared in
testfloat/source/verCases_common.c
+ */
case 's':
verCases_errorStop = true;
break;
+ case 'q':
+ verCases_verbosity = 0;
+ break;
case '?':
/* invalid option or missing argument; getopt prints error info */
exit(EXIT_FAILURE);
diff --git a/tests/fp/berkeley-testfloat-3 b/tests/fp/berkeley-testfloat-3
index 5a59dcec19..40619cbb3b 160000
--- a/tests/fp/berkeley-testfloat-3
+++ b/tests/fp/berkeley-testfloat-3
@@ -1 +1 @@
-Subproject commit 5a59dcec19327396a011a17fd924aed4fec416b3
+Subproject commit 40619cbb3bf32872df8c53cc457039229428a263
diff --git a/tests/fp/meson.build b/tests/fp/meson.build
index 312a4d301f..f9ca6a93b4 100644
--- a/tests/fp/meson.build
+++ b/tests/fp/meson.build
@@ -609,7 +609,7 @@ softfloat_tests = {
# The full test suite can take a bit of time, default to a quick run
# "-l 2 -r all" can take more than a day for some operations and is best
# run manually
-fptest_args = ['-s', '-l', '1']
+fptest_args = ['-q', '-s', '-l', '1']
fptest_rounding_args = ['-r', 'all']
# Conversion Routines:
--
2.39.2
- [PATCH v3 00/24] testing/next: docker, avocado, unit, gitlab, Alex Bennée, 2023/02/28
- [PATCH v3 04/24] tests: make fp-test less chatty when running from test suite,
Alex Bennée <=
- [PATCH v3 01/24] tests: don't run socat tests on MacOS as well, Alex Bennée, 2023/02/28
- [PATCH v3 05/24] gitlab-ci: Use artifacts instead of dumping logs in the Cirrus-CI jobs, Alex Bennée, 2023/02/28
- [PATCH v3 19/24] tests/docker: add USER stanzas to non-lci images, Alex Bennée, 2023/02/28
- [PATCH v3 08/24] testing: update ubuntu2004 to ubuntu2204, Alex Bennée, 2023/02/28
- [PATCH v3 06/24] gitlab: extend custom runners with base_job_template, Alex Bennée, 2023/02/28
- [PATCH v3 02/24] tests: add socat dependency for tests, Alex Bennée, 2023/02/28
- [PATCH v3 11/24] tests/docker: Use binaries for debian-tricore-cross, Alex Bennée, 2023/02/28
- [PATCH v3 10/24] tests: add tuxrun baseline test to avocado, Alex Bennée, 2023/02/28
- [PATCH v3 12/24] tests: ensure we export job results for some cross builds, Alex Bennée, 2023/02/28
- [PATCH v3 13/24] cirrus.yml: Improve the windows_msys2_task, Alex Bennée, 2023/02/28