[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH RESEND v5 07/28] target/arm: Move define_debug_regs() to cpre
From: |
Peter Maydell |
Subject: |
Re: [PATCH RESEND v5 07/28] target/arm: Move define_debug_regs() to cpregs.c |
Date: |
Thu, 16 Feb 2023 16:22:11 +0000 |
On Mon, 13 Feb 2023 at 20:31, Fabiano Rosas <farosas@suse.de> wrote:
>
> The debug_helper.c file will move into a tcg-specific directory, so
> take the cpregs code out of it. That code needs to be present in KVM
> builds as well.
>
> Signed-off-by: Fabiano Rosas <farosas@suse.de>
> Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
> Tested-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
> target/arm/cpregs.c | 473 ++++++++++++++++++++++++++++++++++++++
> target/arm/debug_helper.c | 459 ------------------------------------
> target/arm/internals.h | 9 -
> 3 files changed, 473 insertions(+), 468 deletions(-)
I definitely think this is not an improvement. Currently we
have a file debug_helper.c with a reasonably well defined
purpose (debug related cpregs and code). This patch moves
half of that into the already massively too large cpregs.c,
thus undoing the cleanup we did by separating out the debug
register code from the huge pile of code in helper.c.
thanks
-- PMM
- [PATCH RESEND v5 00/28] target/arm: Allow CONFIG_TCG=n builds, Fabiano Rosas, 2023/02/13
- [PATCH RESEND v5 01/28] target/arm: rename handle_semihosting to tcg_handle_semihosting, Fabiano Rosas, 2023/02/13
- [PATCH RESEND v5 04/28] target/arm: Move PC alignment check, Fabiano Rosas, 2023/02/13
- [PATCH RESEND v5 03/28] target/arm: wrap call to aarch64_sve_change_el in tcg_enabled(), Fabiano Rosas, 2023/02/13
- [PATCH RESEND v5 02/28] target/arm: wrap psci call with tcg_enabled, Fabiano Rosas, 2023/02/13
- [PATCH RESEND v5 05/28] target/arm: Move cpregs code out of cpu.h, Fabiano Rosas, 2023/02/13
- [PATCH RESEND v5 06/28] target/arm: Move cpregs code into cpregs.c, Fabiano Rosas, 2023/02/13
- [PATCH RESEND v5 07/28] target/arm: Move define_debug_regs() to cpregs.c, Fabiano Rosas, 2023/02/13
- Re: [PATCH RESEND v5 07/28] target/arm: Move define_debug_regs() to cpregs.c,
Peter Maydell <=
- [PATCH RESEND v5 08/28] target/arm: Wrap breakpoint/watchpoint updates with tcg_enabled, Fabiano Rosas, 2023/02/13
- [PATCH RESEND v5 09/28] target/arm: move translate modules to tcg/, Fabiano Rosas, 2023/02/13
- [PATCH RESEND v5 10/28] target/arm: move helpers to tcg/, Fabiano Rosas, 2023/02/13
- [PATCH RESEND v5 11/28] target/arm: Move psci.c into the tcg directory, Fabiano Rosas, 2023/02/13
- [PATCH RESEND v5 12/28] target/arm: Wrap arm_rebuild_hflags calls with tcg_enabled, Fabiano Rosas, 2023/02/13
- [PATCH RESEND v5 13/28] target/arm: Move hflags code into the tcg directory, Fabiano Rosas, 2023/02/13
- [PATCH RESEND v5 14/28] target/arm: Move regime_using_lpae_format into internal.h, Fabiano Rosas, 2023/02/13
- [PATCH RESEND v5 15/28] target/arm: Don't access TCG code when debugging with KVM, Fabiano Rosas, 2023/02/13
- [PATCH RESEND v5 16/28] cpu-defs.h: Expose CPUTLBEntryFull to non-TCG code, Fabiano Rosas, 2023/02/13
- [PATCH RESEND v5 17/28] target/arm: Move cortex sysregs into cpregs.c, Fabiano Rosas, 2023/02/13