|
From: | Zenghui Yu |
Subject: | Re: [PATCH] hvf: arm: Add support for GICv3 |
Date: | Tue, 20 Dec 2022 22:13:19 +0800 |
User-agent: | Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.9.0 |
On 2022/12/20 15:37, Alexander Graf wrote:
Hi Zenghui, On 20.12.22 08:14, Zenghui Yu wrote:On 2022/12/20 6:08, Alexander Graf wrote:We currently only support GICv2 emulation.Before looking into it, I think it's worth finalizing the GIC version in the hvf case - only v2 is allowed and fail early if user selects the unsupported versions. Currently finalize_gic_version() does not deal with hvf at all.Currently finalize_gic_version() treats HVF the same as TCG, which is incorrect. However, with this patch applied, they happen to match.I don't think it's worth changing the finalize_gic_version() implementation to reflect the gicv2 only state for HVF. Instead, let's rather get GICv3 support in and then add explicit handling for HVF on top.
I'm fine with it. I was just a bit confused when the guest got stuck with a (blindly selected) gic-version but *no* error_report like "Hey, please do not try GIC version other than v2" was printed. Apparently I'm not familiar with how things work on my M1. ;-) I'll have a try with this patch. Thanks.
[Prev in Thread] | Current Thread | [Next in Thread] |