[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 41/42] target/arm: Implement FEAT_HAFDBS
From: |
Peter Maydell |
Subject: |
Re: [PATCH v3 41/42] target/arm: Implement FEAT_HAFDBS |
Date: |
Fri, 7 Oct 2022 17:50:33 +0100 |
On Fri, 7 Oct 2022 at 17:45, Richard Henderson
<richard.henderson@linaro.org> wrote:
>
> On 10/7/22 06:47, Peter Maydell wrote:
> > Are there definitely no code paths where we might try to do
> > a page table walk with the iothread already locked ?
>
> I'll double-check, but another possibility is to simply perform the atomic
> operation on
> the low 32-bits, where both AF and DB are located. Another trick I learned
> from x86...
Doesn't that cause a problem where we don't detect that some other
CPU wrote to the high 32 bits of the descriptor ? We're supposed to
be using those high 32 bits, not the ones we have in hand...
If we do need the iothread lock, we could do it the way that
io_readx() does, I guess, where we track whether we needed to
lock it or not.
thanks
-- PMM
- [PATCH v3 37/42] target/arm: Remove loop from get_phys_addr_lpae, (continued)
[PATCH v3 42/42] target/arm: Use the max page size in a 2-stage ptw, Richard Henderson, 2022/10/01
[PATCH v3 40/42] target/arm: Consider GP an attribute in get_phys_addr_lpae, Richard Henderson, 2022/10/01
Re: [PATCH v3 00/42] target/arm: Implement FEAT_HAFDBS, Peter Maydell, 2022/10/10