[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v4 2/9] target/arm: Change gen_goto_tb to work on displacemen
From: |
Peter Maydell |
Subject: |
Re: [PATCH v4 2/9] target/arm: Change gen_goto_tb to work on displacements |
Date: |
Thu, 22 Sep 2022 15:01:37 +0100 |
On Tue, 6 Sept 2022 at 11:12, Richard Henderson
<richard.henderson@linaro.org> wrote:
>
> In preparation for TARGET_TB_PCREL, reduce reliance on absolute values.
>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
> target/arm/translate-a64.c | 40 ++++++++++++++++++++------------------
> target/arm/translate.c | 10 ++++++----
> 2 files changed, 27 insertions(+), 23 deletions(-)
>
> @@ -14965,7 +14967,7 @@ static void aarch64_tr_tb_stop(DisasContextBase
> *dcbase, CPUState *cpu)
> switch (dc->base.is_jmp) {
> case DISAS_NEXT:
> case DISAS_TOO_MANY:
> - gen_goto_tb(dc, 1, dc->base.pc_next);
> + gen_goto_tb(dc, 1, curr_insn_len(dc));
Why does this one need to be curr_insn_len() when all the others
in translate-a64.c used a hardcoded 4 ?
Otherwise
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
thanks
-- PMM
- [PATCH v4 0/9] target/arm: pc-relative translation blocks, Richard Henderson, 2022/09/06
- [PATCH v4 7/9] target/arm: Introduce gen_pc_plus_diff for aarch64, Richard Henderson, 2022/09/06
- [PATCH v4 2/9] target/arm: Change gen_goto_tb to work on displacements, Richard Henderson, 2022/09/06
- [PATCH v4 4/9] target/arm: Change gen_exception_insn* to work on displacements, Richard Henderson, 2022/09/06
- [PATCH v4 6/9] target/arm: Change gen_jmp* to work on displacements, Richard Henderson, 2022/09/06
- [PATCH v4 1/9] target/arm: Introduce curr_insn_len, Richard Henderson, 2022/09/06
- [PATCH v4 5/9] target/arm: Change gen_exception_internal to work on displacements, Richard Henderson, 2022/09/06
- [PATCH v4 3/9] target/arm: Change gen_*set_pc_im to gen_*update_pc, Richard Henderson, 2022/09/06
- [PATCH v4 8/9] target/arm: Introduce gen_pc_plus_diff for aarch32, Richard Henderson, 2022/09/06