[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v9 0/6] hw/arm/virt: Fix CPU's default NUMA node ID
From: |
Peter Maydell |
Subject: |
Re: [PATCH v9 0/6] hw/arm/virt: Fix CPU's default NUMA node ID |
Date: |
Mon, 9 May 2022 11:47:09 +0100 |
On Mon, 9 May 2022 at 04:08, Gavin Shan <gshan@redhat.com> wrote:
>
> Hi Peter and maintainers,
>
> On 5/3/22 10:02 PM, Gavin Shan wrote:
> > When the CPU-to-NUMA association isn't provided by user, the default NUMA
> > node ID for the specific CPU is returned from
> > virt_get_default_cpu_node_id().
> > Unfortunately, the default NUMA node ID breaks socket boundary and leads to
> > the broken CPU topology warning message in Linux guest. This series intends
> > to fix the issue by populating full CPU toplogy on arm/virt machine.
> >
> > PATCH[1/6] Add cluster-id to CPU instance property
> > PATCH[2/6] Fixes test failure in qtest/numa-test/aarch64_numa_cpu()
> > PATCH[3/6] Uses SMP configuration to populate CPU topology
> > PATCH[4/6] Corrects CPU/NUMA association in
> > qtest/numa-test/aarch64_numa_cpu()
> > PATCH[5/6] Fixes the broken CPU topology by considering the socket
> > boundary
> > when the default NUMA node ID is given
> > PATCH[6/6] Uses the populated CPU topology to build PPTT table, instead
> > of
> > calculate it again
> >
> > Changelog
> > =========
> > v9:
> > * Fix typo by replacing 'thrad-id' with 'thread-id' in
> > PATCH[v9 2/6]'s commit log (Igor)
> > * Added PATCH[v9 4/6] to make CPU-to-NUMA association
> > real (Igor)
>
> [...]
>
> > Gavin Shan (6):
> > qapi/machine.json: Add cluster-id
> > qtest/numa-test: Specify CPU topology in aarch64_numa_cpu()
> > hw/arm/virt: Consider SMP configuration in CPU topology
> > qtest/numa-test: Correct CPU and NUMA association in
> > aarch64_numa_cpu()
> > hw/arm/virt: Fix CPU's default NUMA node ID
> > hw/acpi/aml-build: Use existing CPU topology to build PPTT table
> >
> > hw/acpi/aml-build.c | 111 ++++++++++++++++---------------------
> > hw/arm/virt.c | 19 ++++++-
> > hw/core/machine-hmp-cmds.c | 4 ++
> > hw/core/machine.c | 16 ++++++
> > qapi/machine.json | 6 +-
> > tests/qtest/numa-test.c | 19 +++++--
> > 6 files changed, 102 insertions(+), 73 deletions(-)
> >
>
> I think this series is ready to be merged. Could you help to see how it
> can be merged to QEMU 7.1?
Applied to target-arm.next, thanks.
-- PMM
- [PATCH v9 0/6] hw/arm/virt: Fix CPU's default NUMA node ID, Gavin Shan, 2022/05/03
- [PATCH v9 2/6] qtest/numa-test: Specify CPU topology in aarch64_numa_cpu(), Gavin Shan, 2022/05/03
- [PATCH v9 3/6] hw/arm/virt: Consider SMP configuration in CPU topology, Gavin Shan, 2022/05/03
- [PATCH v9 6/6] hw/acpi/aml-build: Use existing CPU topology to build PPTT table, Gavin Shan, 2022/05/03
- [PATCH v9 5/6] hw/arm/virt: Fix CPU's default NUMA node ID, Gavin Shan, 2022/05/03
- [PATCH v9 1/6] qapi/machine.json: Add cluster-id, Gavin Shan, 2022/05/03
- [PATCH v9 4/6] qtest/numa-test: Correct CPU and NUMA association in aarch64_numa_cpu(), Gavin Shan, 2022/05/03
- Re: [PATCH v9 0/6] hw/arm/virt: Fix CPU's default NUMA node ID, Gavin Shan, 2022/05/08
- Re: [PATCH v9 0/6] hw/arm/virt: Fix CPU's default NUMA node ID,
Peter Maydell <=