[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 2/6] hw/acpi: Add VIOT table
From: |
Jean-Philippe Brucker |
Subject: |
Re: [PATCH 2/6] hw/acpi: Add VIOT table |
Date: |
Fri, 27 Aug 2021 15:29:38 +0200 |
On Tue, Aug 10, 2021 at 11:22:27AM +0200, Igor Mammedov wrote:
> On Tue, 10 Aug 2021 10:45:02 +0200
> Jean-Philippe Brucker <jean-philippe@linaro.org> wrote:
>
> > Add a function that generates a Virtual I/O Translation table (VIOT),
> > describing the topology of paravirtual IOMMUs. The table is created when
> > instantiating a virtio-iommu device. It contains a virtio-iommu node and
> > PCI Range nodes for endpoints managed by the IOMMU. By default, a single
> > node describes all PCI devices. When passing the "default_bus_bypass_iommu"
> > machine option and "bypass_iommu" PXB option, only buses that do not
> > bypass the IOMMU are described by PCI Range nodes.
> >
> > Signed-off-by: Jean-Philippe Brucker <jean-philippe@linaro.org>
>
>
> using packed structures for composing ACPI tables is discouraged,
> pls use build_append_int_noprefix() API instead. You can look at
> build_amd_iommu() as an example.
>
> PS:
> Also note field comments format.
> /it should be verbatim copy of entry name from respective table in spec/
Got it, I'll switch to build_append_int_noprefix()
Thanks,
Jean
- [PATCH 0/6] virtio-iommu: Add ACPI support, Jean-Philippe Brucker, 2021/08/10
- [PATCH 1/6] acpi: Add VIOT structure definitions, Jean-Philippe Brucker, 2021/08/10
- [PATCH 3/6] hw/arm/virt-acpi-build: Add VIOT table for virtio-iommu, Jean-Philippe Brucker, 2021/08/10
- [PATCH 4/6] hw/arm/virt: Remove device tree restriction for virtio-iommu, Jean-Philippe Brucker, 2021/08/10
- [PATCH 2/6] hw/acpi: Add VIOT table, Jean-Philippe Brucker, 2021/08/10
- [PATCH 5/6] pc: Add VIOT table for virtio-iommu, Jean-Philippe Brucker, 2021/08/10
- [PATCH 6/6] pc: Allow instantiating a virtio-iommu device, Jean-Philippe Brucker, 2021/08/10
- Re: [PATCH 0/6] virtio-iommu: Add ACPI support, Eric Auger, 2021/08/17