[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH for-6.2 07/25] armsse: Wire up systick cpuclk clock
From: |
Alistair Francis |
Subject: |
Re: [PATCH for-6.2 07/25] armsse: Wire up systick cpuclk clock |
Date: |
Fri, 13 Aug 2021 11:29:49 +1000 |
On Thu, Aug 12, 2021 at 7:42 PM Peter Maydell <peter.maydell@linaro.org> wrote:
>
> Wire up the cpuclk for the systick devices to the SSE object's
> existing mainclk clock.
>
> We do not wire up the refclk because the SSE subsystems do not
> provide a refclk. (This is documented in the IoTKit and SSE-200
> TRMs; the SSE-300 TRM doesn't mention it but we assume it follows the
> same approach.) When we update the systick device later to honour "no
> refclk connected" this will fix a minor emulation inaccuracy for the
> SSE-based boards.
>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Acked-by: Alistair Francis <alistair.francis@wdc.com>
Alistair
> ---
> hw/arm/armsse.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/hw/arm/armsse.c b/hw/arm/armsse.c
> index a1456cb0f42..70b52c3d4b9 100644
> --- a/hw/arm/armsse.c
> +++ b/hw/arm/armsse.c
> @@ -995,6 +995,9 @@ static void armsse_realize(DeviceState *dev, Error **errp)
> int j;
> char *gpioname;
>
> + qdev_connect_clock_in(cpudev, "cpuclk", s->mainclk);
> + /* The SSE subsystems do not wire up a systick refclk */
> +
> qdev_prop_set_uint32(cpudev, "num-irq", s->exp_numirq +
> NUM_SSE_IRQS);
> /*
> * In real hardware the initial Secure VTOR is set from the
> INITSVTOR*
> --
> 2.20.1
>
>
- [PATCH for-6.2 02/25] arm: Move systick device creation from NVIC to ARMv7M object, (continued)
- [PATCH for-6.2 02/25] arm: Move systick device creation from NVIC to ARMv7M object, Peter Maydell, 2021/08/12
- [PATCH for-6.2 04/25] hw/timer/armv7m_systick: Add usual QEMU interface comment, Peter Maydell, 2021/08/12
- [PATCH for-6.2 03/25] arm: Move system PPB container handling to armv7m, Peter Maydell, 2021/08/12
- [PATCH for-6.2 07/25] armsse: Wire up systick cpuclk clock, Peter Maydell, 2021/08/12
- [PATCH for-6.2 05/25] hw/timer/armv7m_systick: Add input clocks, Peter Maydell, 2021/08/12
- [PATCH for-6.2 08/25] hw/arm/mps2.c: Connect up armv7m clocks, Peter Maydell, 2021/08/12
- [PATCH for-6.2 06/25] hw/arm/armv7m: Create input clocks, Peter Maydell, 2021/08/12
- [PATCH for-6.2 09/25] clock: Provide builtin multiplier/divider, Peter Maydell, 2021/08/12