|
From: | Thomas Huth |
Subject: | Re: [PATCH v16 96/99] tests/qtest: split the cdrom-test into arm/aarch64 |
Date: | Tue, 8 Jun 2021 16:42:43 +0200 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.0 |
On 08/06/2021 16.27, Alex Bennée wrote:
Richard Henderson <richard.henderson@linaro.org> writes:On 6/4/21 8:53 AM, Alex Bennée wrote:The assumption that the qemu-system-aarch64 image can run all 32 bit machines is about to be broken...Um, what?Really what we want is to probe the -M (machines) that a binary supports rather than just barfing the test because we've built a QEMU that doesn't support all the random 32 bit machines.
Ok, so this is rather about being able to use the qtests with custom QEMU builds where you tweaked the default-configs? That's certainly a valid endeavor, but then I think this patch is the wrong way to go. You should rather add a qtest_has_machine() function that checks whether a machine is available in the target binary or not, and then only add the tests to the test plan that match the list of available machines. (we have similar issues in downstream RHEL where we want to limit the amount of machines, so a qtest_has_machine() function would certainly be welcome)
Thomas
[Prev in Thread] | Current Thread | [Next in Thread] |