[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/3] hw/usb/Kconfig: Introduce USB_CHIPIDEA symbol
From: |
Peter Maydell |
Subject: |
Re: [PATCH 1/3] hw/usb/Kconfig: Introduce USB_CHIPIDEA symbol |
Date: |
Thu, 27 May 2021 10:27:39 +0100 |
On Wed, 19 May 2021 at 21:09, Philippe Mathieu-Daudé <f4bug@amsat.org> wrote:
>
> Currently the TYPE_CHIPIDEA model is only built when the IMX
> machines are built. Since it is not specific to IMX, add its
> symbol to allow other machines to use it.
>
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
> hw/arm/Kconfig | 4 ++++
> hw/usb/Kconfig | 3 +++
> hw/usb/meson.build | 2 +-
> 3 files changed, 8 insertions(+), 1 deletion(-)
>
> diff --git a/hw/arm/Kconfig b/hw/arm/Kconfig
> index b887f6a5b17..585de92f00a 100644
> --- a/hw/arm/Kconfig
> +++ b/hw/arm/Kconfig
> @@ -385,6 +385,7 @@ config FSL_IMX25
> select IMX_I2C
> select WDT_IMX2
> select DS1338
> + select USB_CHIPIDEA
>
> config FSL_IMX31
> bool
> @@ -403,6 +404,7 @@ config FSL_IMX6
> select IMX_USBPHY
> select WDT_IMX2
> select SDHCI
> + select USB_CHIPIDEA
>
> config ASPEED_SOC
> bool
> @@ -447,6 +449,7 @@ config FSL_IMX7
> select PCI_EXPRESS_DESIGNWARE
> select SDHCI
> select UNIMP
> + select USB_CHIPIDEA
>
> config ARM_SMMUV3
> bool
> @@ -460,6 +463,7 @@ config FSL_IMX6UL
> select WDT_IMX2
> select SDHCI
> select UNIMP
> + select USB_CHIPIDEA
>
> config MICROBIT
> bool
Missing "select USB_CHIPIDEA" in "config FSL_IMX31" ?
(Side note: is it worth moving the FSL_* config sections so
they're all next to each other? We seem to have allowed them
to become separated by some other unrelated sections...)
thanks
-- PMM