[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/3] target/arm: Remove redundant mmu_idx lookup
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [PATCH 1/3] target/arm: Remove redundant mmu_idx lookup |
Date: |
Thu, 8 Oct 2020 18:32:17 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 |
On 10/8/20 6:21 PM, Richard Henderson wrote:
> We already have the full ARMMMUIdx as computed from the
> function parameter.
>
> For the purpose of regime_has_2_ranges, we can ignore any
> difference between AccType_Normal and AccType_Unpriv, which
> would be the only difference between the passed mmu_idx
> and arm_mmu_idx_el.
>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
> target/arm/mte_helper.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/target/arm/mte_helper.c b/target/arm/mte_helper.c
> index 5615c6706c..734cc5ca67 100644
> --- a/target/arm/mte_helper.c
> +++ b/target/arm/mte_helper.c
> @@ -563,8 +563,7 @@ static void mte_check_fail(CPUARMState *env, uint32_t
> desc,
>
> case 2:
> /* Tag check fail causes asynchronous flag set. */
> - mmu_idx = arm_mmu_idx_el(env, el);
> - if (regime_has_2_ranges(mmu_idx)) {
> + if (regime_has_2_ranges(arm_mmu_idx)) {
> select = extract64(dirty_ptr, 55, 1);
> } else {
> select = 0;
>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
- [PATCH 0/3] target/arm: MTE fixes, Richard Henderson, 2020/10/08
- [PATCH 2/3] target/arm: Fix reported EL for mte_check_fail, Richard Henderson, 2020/10/08
- [PATCH 3/3] target/arm: Ignore HCR_EL2.ATA when {E2H,TGE} != 11, Richard Henderson, 2020/10/08
- [PATCH 1/3] target/arm: Remove redundant mmu_idx lookup, Richard Henderson, 2020/10/08
- Re: [PATCH 0/3] target/arm: MTE fixes, Vincenzo Frascino, 2020/10/09
- Re: [PATCH 0/3] target/arm: MTE fixes, Peter Maydell, 2020/10/20