[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 2/2] hw/arm/sbsa-ref : allocate IRQs for SMMUv3
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [PATCH v2 2/2] hw/arm/sbsa-ref : allocate IRQs for SMMUv3 |
Date: |
Wed, 7 Oct 2020 12:25:27 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 |
On 10/7/20 12:07 PM, Graeme Gregory wrote:
> Original commit did not allocate IRQs for the SMMUv3 in the irqmap
> effectively using irq 0->3 (shared with other devices). Assuming
> original intent was to allocate unique IRQs then add an allocation
> to the irqmap.
>
> Fixes: e9fdf453240 ("hw/arm: Add arm SBSA reference machine, devices part")
> Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Previous version also has:
Reviewed-by: Eric Auger <eric.auger@redhat.com>
> Signed-off-by: Graeme Gregory <graeme@nuviainc.com>
> ---
> hw/arm/sbsa-ref.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/hw/arm/sbsa-ref.c b/hw/arm/sbsa-ref.c
> index 65e64883b5..01863510d0 100644
> --- a/hw/arm/sbsa-ref.c
> +++ b/hw/arm/sbsa-ref.c
> @@ -133,6 +133,7 @@ static const int sbsa_ref_irqmap[] = {
> [SBSA_SECURE_UART_MM] = 9,
> [SBSA_AHCI] = 10,
> [SBSA_EHCI] = 11,
> + [SBSA_SMMU] = 12, /* ... to 15 */
> };
>
> static uint64_t sbsa_ref_cpu_mp_affinity(SBSAMachineState *sms, int idx)
>
[PATCH v2 2/2] hw/arm/sbsa-ref : allocate IRQs for SMMUv3, Graeme Gregory, 2020/10/07
- Re: [PATCH v2 2/2] hw/arm/sbsa-ref : allocate IRQs for SMMUv3,
Philippe Mathieu-Daudé <=
Re: [PATCH v2 0/2] hw/arm/sbsa-ref : small fixes to smmuv3 initialisation, Peter Maydell, 2020/10/08