[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 01/13] pci: pass along the return value of dma_memory_rw
From: |
Li Qiang |
Subject: |
Re: [PATCH 01/13] pci: pass along the return value of dma_memory_rw |
Date: |
Mon, 7 Sep 2020 09:00:46 +0800 |
Philippe Mathieu-Daudé <philmd@redhat.com> 于2020年9月4日周五 下午11:47写道:
>
> From: Klaus Jensen <k.jensen@samsung.com>
>
> Some might actually care about the return value of dma_memory_rw. So
> let us pass it along instead of ignoring it.
>
> There are no existing users of the return value, so this patch should be
> safe.
>
> Signed-off-by: Klaus Jensen <k.jensen@samsung.com>
> Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
> Acked-by: Keith Busch <kbusch@kernel.org>
> Message-Id: <20191011070141.188713-2-its@irrelevant.dk>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: Li Qiang <liq3ea@gmail.com>
> ---
> include/hw/pci/pci.h | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/include/hw/pci/pci.h b/include/hw/pci/pci.h
> index 4ca7258b5b7..896cef9ad47 100644
> --- a/include/hw/pci/pci.h
> +++ b/include/hw/pci/pci.h
> @@ -788,8 +788,7 @@ static inline AddressSpace
> *pci_get_address_space(PCIDevice *dev)
> static inline int pci_dma_rw(PCIDevice *dev, dma_addr_t addr,
> void *buf, dma_addr_t len, DMADirection dir)
> {
> - dma_memory_rw(pci_get_address_space(dev), addr, buf, len, dir);
> - return 0;
> + return dma_memory_rw(pci_get_address_space(dev), addr, buf, len, dir);
> }
>
> static inline int pci_dma_read(PCIDevice *dev, dma_addr_t addr,
> --
> 2.26.2
>
>
- [PATCH 00/13] dma: Let the DMA API take MemTxAttrs argument and propagate MemTxResult, Philippe Mathieu-Daudé, 2020/09/04
- [PATCH 01/13] pci: pass along the return value of dma_memory_rw, Philippe Mathieu-Daudé, 2020/09/04
- [PATCH 02/13] docs/devel/loads-stores: Add regexp for DMA functions, Philippe Mathieu-Daudé, 2020/09/04
- [PATCH 03/13] dma: Document address_space_map/address_space_unmap() prototypes, Philippe Mathieu-Daudé, 2020/09/04
- [PATCH 04/13] dma: Let dma_memory_set() propagate MemTxResult, Philippe Mathieu-Daudé, 2020/09/04
- [PATCH 05/13] dma: Let dma_memory_rw() propagate MemTxResult, Philippe Mathieu-Daudé, 2020/09/04