[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v6 13/20] x86: constify x86_machine_is_*_enabled
From: |
Sergio Lopez |
Subject: |
Re: [PATCH v6 13/20] x86: constify x86_machine_is_*_enabled |
Date: |
Thu, 27 Aug 2020 16:56:32 +0200 |
On Wed, Aug 26, 2020 at 12:52:47PM +0200, Gerd Hoffmann wrote:
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
> ---
> include/hw/i386/x86.h | 4 ++--
> hw/i386/x86.c | 4 ++--
> 2 files changed, 4 insertions(+), 4 deletions(-)
Reviewed-by: Sergio Lopez <slp@redhat.com>
> diff --git a/include/hw/i386/x86.h b/include/hw/i386/x86.h
> index b79f24e28545..a350ea3609f5 100644
> --- a/include/hw/i386/x86.h
> +++ b/include/hw/i386/x86.h
> @@ -110,8 +110,8 @@ void x86_load_linux(X86MachineState *x86ms,
> bool pvh_enabled,
> bool linuxboot_dma_enabled);
>
> -bool x86_machine_is_smm_enabled(X86MachineState *x86ms);
> -bool x86_machine_is_acpi_enabled(X86MachineState *x86ms);
> +bool x86_machine_is_smm_enabled(const X86MachineState *x86ms);
> +bool x86_machine_is_acpi_enabled(const X86MachineState *x86ms);
>
> /* Global System Interrupts */
>
> diff --git a/hw/i386/x86.c b/hw/i386/x86.c
> index cf384b974318..31a82885d735 100644
> --- a/hw/i386/x86.c
> +++ b/hw/i386/x86.c
> @@ -845,7 +845,7 @@ void x86_bios_rom_init(MemoryRegion *rom_memory, bool
> isapc_ram_fw)
> bios);
> }
>
> -bool x86_machine_is_smm_enabled(X86MachineState *x86ms)
> +bool x86_machine_is_smm_enabled(const X86MachineState *x86ms)
> {
> bool smm_available = false;
>
> @@ -887,7 +887,7 @@ static void x86_machine_set_smm(Object *obj, Visitor *v,
> const char *name,
> visit_type_OnOffAuto(v, name, &x86ms->smm, errp);
> }
>
> -bool x86_machine_is_acpi_enabled(X86MachineState *x86ms)
> +bool x86_machine_is_acpi_enabled(const X86MachineState *x86ms)
> {
> if (x86ms->acpi == ON_OFF_AUTO_OFF) {
> return false;
> --
> 2.27.0
>
signature.asc
Description: PGP signature
- Re: [PATCH v6 11/20] microvm/acpi: use seabios with acpi=on, (continued)
- [PATCH v6 16/20] microvm: wire up hotplug, Gerd Hoffmann, 2020/08/26
- [PATCH v6 14/20] x86: move acpi_dev from pc/microvm, Gerd Hoffmann, 2020/08/26
- [PATCH v6 18/20] tests/acpi: allow override blkdev, Gerd Hoffmann, 2020/08/26
- [PATCH v6 06/20] acpi: move acpi_dsdt_add_power_button() to ged, Gerd Hoffmann, 2020/08/26
- [PATCH v6 13/20] x86: constify x86_machine_is_*_enabled, Gerd Hoffmann, 2020/08/26