[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 07/26] hw/usb/hcd-dwc2: Restrict some headers to source
From: |
Philippe Mathieu-Daudé |
Subject: |
[PATCH 07/26] hw/usb/hcd-dwc2: Restrict some headers to source |
Date: |
Sat, 4 Jul 2020 16:49:24 +0200 |
The header "usb/hcd-dwc2.h" doesn't need to include "qemu/timer.h",
"sysemu/dma.h", "hw/irq.h" (the types required are forward declared).
Include them in the source file which is the only one requiring the
function declarations.
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
hw/usb/hcd-dwc2.h | 3 ---
hw/usb/hcd-dwc2.c | 3 +++
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/hw/usb/hcd-dwc2.h b/hw/usb/hcd-dwc2.h
index 4ba809a07b..2adf0f53c7 100644
--- a/hw/usb/hcd-dwc2.h
+++ b/hw/usb/hcd-dwc2.h
@@ -19,11 +19,8 @@
#ifndef HW_USB_DWC2_H
#define HW_USB_DWC2_H
-#include "qemu/timer.h"
-#include "hw/irq.h"
#include "hw/sysbus.h"
#include "hw/usb.h"
-#include "sysemu/dma.h"
#define DWC2_MMIO_SIZE 0x11000
diff --git a/hw/usb/hcd-dwc2.c b/hw/usb/hcd-dwc2.c
index 590e75b455..ccf05d0823 100644
--- a/hw/usb/hcd-dwc2.c
+++ b/hw/usb/hcd-dwc2.c
@@ -36,8 +36,11 @@
#include "qapi/error.h"
#include "hw/usb/dwc2-regs.h"
#include "hw/usb/hcd-dwc2.h"
+#include "hw/irq.h"
+#include "sysemu/dma.h"
#include "migration/vmstate.h"
#include "trace.h"
+#include "qemu/timer.h"
#include "qemu/log.h"
#include "hw/qdev-properties.h"
--
2.21.3
- Re: [PATCH 02/26] hw/ppc/sam460ex: Add missing 'hw/pci/pci.h' header, (continued)
- [PATCH 03/26] hw/usb: Remove unused VM_USB_HUB_SIZE definition, Philippe Mathieu-Daudé, 2020/07/04
- [PATCH 04/26] hw/usb: Reduce 'exec/memory.h' inclusion, Philippe Mathieu-Daudé, 2020/07/04
- [PATCH 05/26] hw/usb/desc: Add missing header, Philippe Mathieu-Daudé, 2020/07/04
- [PATCH 06/26] hw/usb/hcd-dwc2: Remove unnecessary includes, Philippe Mathieu-Daudé, 2020/07/04
- [PATCH 07/26] hw/usb/hcd-dwc2: Restrict some headers to source,
Philippe Mathieu-Daudé <=
- [PATCH 08/26] hw/usb/hcd-dwc2: Restrict 'dwc2-regs.h' scope, Philippe Mathieu-Daudé, 2020/07/04
- [PATCH 09/26] hw/usb/hcd-ehci: Remove unnecessary include, Philippe Mathieu-Daudé, 2020/07/04
- [PATCH 10/26] hw/usb/hcd-ehci: Move few definitions from header to source, Philippe Mathieu-Daudé, 2020/07/04
- [PATCH 11/26] hw/usb/hcd-xhci: Add missing header, Philippe Mathieu-Daudé, 2020/07/04