[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v2 2/8] hw/pci-host/prep: Correct RAVEN bus bridge memory region
From: |
Philippe Mathieu-Daudé |
Subject: |
[PATCH v2 2/8] hw/pci-host/prep: Correct RAVEN bus bridge memory region size |
Date: |
Mon, 1 Jun 2020 16:29:24 +0200 |
memory_region_set_size() handle the 16 Exabytes limit by
special-casing the UINT64_MAX value. This is not a problem
for the 32-bit maximum, 4 GiB.
By using the UINT32_MAX value, the bm-raven MemoryRegion
ends up missing 1 byte:
$ qemu-system-ppc -M prep -S -monitor stdio -usb
memory-region: bm-raven
0000000000000000-00000000fffffffe (prio 0, i/o): bm-raven
0000000000000000-000000003effffff (prio 0, i/o): alias bm-pci-memory
@pci-memory 0000000000000000-000000003effffff
0000000080000000-00000000ffffffff (prio 0, i/o): alias bm-system @system
0000000000000000-000000007fffffff
Fix by using the correct value. We now have:
memory-region: bm-raven
0000000000000000-00000000ffffffff (prio 0, i/o): bm-raven
0000000000000000-000000003effffff (prio 0, i/o): alias bm-pci-memory
@pci-memory 0000000000000000-000000003effffff
0000000080000000-00000000ffffffff (prio 0, i/o): alias bm-system @system
0000000000000000-000000007fffffff
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
hw/pci-host/prep.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/pci-host/prep.c b/hw/pci-host/prep.c
index 1a02e9a670..88e2fc66a9 100644
--- a/hw/pci-host/prep.c
+++ b/hw/pci-host/prep.c
@@ -294,7 +294,7 @@ static void raven_pcihost_initfn(Object *obj)
&s->pci_memory, &s->pci_io, 0, TYPE_PCI_BUS);
/* Bus master address space */
- memory_region_init(&s->bm, obj, "bm-raven", UINT32_MAX);
+ memory_region_init(&s->bm, obj, "bm-raven", 4 * GiB);
memory_region_init_alias(&s->bm_pci_memory_alias, obj, "bm-pci-memory",
&s->pci_memory, 0,
memory_region_size(&s->pci_memory));
--
2.21.3
- [PATCH v2 0/8] hw: Fix some incomplete memory region size, Philippe Mathieu-Daudé, 2020/06/01
- [PATCH v2 1/8] hw/arm/aspeed: Correct DRAM container region size, Philippe Mathieu-Daudé, 2020/06/01
- [PATCH v2 2/8] hw/pci-host/prep: Correct RAVEN bus bridge memory region size,
Philippe Mathieu-Daudé <=
- [PATCH v2 5/8] hw/pci-host: Use the IEC binary prefix definitions, Philippe Mathieu-Daudé, 2020/06/01
- [PATCH v2 3/8] hw/pci/pci_bridge: Correct pci_bridge_io memory region size, Philippe Mathieu-Daudé, 2020/06/01
- [PATCH v2 7/8] hw/i386/xen/xen-hvm: Use the IEC binary prefix definitions, Philippe Mathieu-Daudé, 2020/06/01
- [PATCH v2 8/8] target/i386/cpu: Use the IEC binary prefix definitions, Philippe Mathieu-Daudé, 2020/06/01