[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 3/4] hw/char/xilinx_uartlite: Replace hw_error() by qemu_l
From: |
Alistair Francis |
Subject: |
Re: [PATCH v2 3/4] hw/char/xilinx_uartlite: Replace hw_error() by qemu_log_mask() |
Date: |
Mon, 18 May 2020 09:43:34 -0700 |
On Mon, May 18, 2020 at 7:04 AM Philippe Mathieu-Daudé <address@hidden> wrote:
>
> hw_error() calls exit(). This a bit overkill when we can log
> the accesses as unimplemented or guest error.
>
> When fuzzing the devices, we don't want the whole process to
> exit. Replace some hw_error() calls by qemu_log_mask().
>
> Reviewed-by: Edgar E. Iglesias <address@hidden>
> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
Reviewed-by: Alistair Francis <address@hidden>
Alistair
> ---
> hw/char/xilinx_uartlite.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/hw/char/xilinx_uartlite.c b/hw/char/xilinx_uartlite.c
> index c6512285d7..ae4ccd00c7 100644
> --- a/hw/char/xilinx_uartlite.c
> +++ b/hw/char/xilinx_uartlite.c
> @@ -23,7 +23,7 @@
> */
>
> #include "qemu/osdep.h"
> -#include "hw/hw.h"
> +#include "qemu/log.h"
> #include "hw/irq.h"
> #include "hw/qdev-properties.h"
> #include "hw/sysbus.h"
> @@ -135,7 +135,8 @@ uart_write(void *opaque, hwaddr addr,
> switch (addr)
> {
> case R_STATUS:
> - hw_error("write to UART STATUS?\n");
> + qemu_log_mask(LOG_GUEST_ERROR, "%s: write to UART STATUS\n",
> + __func__);
> break;
>
> case R_CTRL:
> --
> 2.21.3
>
>
- [PATCH v2 0/4] hw/arm: Replace hw_error() by qemu_log_mask(), Philippe Mathieu-Daudé, 2020/05/18
- [PATCH v2 1/4] hw/arm/integratorcp: Replace hw_error() by qemu_log_mask(), Philippe Mathieu-Daudé, 2020/05/18
- [PATCH v2 2/4] hw/arm/pxa2xx: Replace hw_error() by qemu_log_mask(), Philippe Mathieu-Daudé, 2020/05/18
- [PATCH v2 3/4] hw/char/xilinx_uartlite: Replace hw_error() by qemu_log_mask(), Philippe Mathieu-Daudé, 2020/05/18
- Re: [PATCH v2 3/4] hw/char/xilinx_uartlite: Replace hw_error() by qemu_log_mask(),
Alistair Francis <=
- [PATCH v2 4/4] hw/timer/exynos4210_mct: Replace hw_error() by qemu_log_mask(), Philippe Mathieu-Daudé, 2020/05/18
- Re: [PATCH v2 0/4] hw/arm: Replace hw_error() by qemu_log_mask(), Peter Maydell, 2020/05/21