[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[kvm-unit-tests PATCH v7 03/13] arm/arm64: gic: Introduce setup_irq() he
From: |
Eric Auger |
Subject: |
[kvm-unit-tests PATCH v7 03/13] arm/arm64: gic: Introduce setup_irq() helper |
Date: |
Fri, 20 Mar 2020 10:24:18 +0100 |
ipi_enable() code would be reusable for other interrupts
than IPI. Let's rename it setup_irq() and pass an interrupt
handler pointer.
Signed-off-by: Eric Auger <address@hidden>
---
v4 -> v5:
- s/handler_t/irq_handler_t
- also add irq_handler_fn in lib/arm/asm/processor.h
v2 -> v3:
- do not export setup_irq anymore
---
arm/gic.c | 19 ++++++-------------
lib/arm/asm/processor.h | 2 ++
2 files changed, 8 insertions(+), 13 deletions(-)
diff --git a/arm/gic.c b/arm/gic.c
index fcf4c1f..2f904b0 100644
--- a/arm/gic.c
+++ b/arm/gic.c
@@ -215,20 +215,20 @@ static void ipi_test_smp(void)
report_prefix_pop();
}
-static void ipi_enable(void)
+static void setup_irq(irq_handler_fn handler)
{
gic_enable_defaults();
#ifdef __arm__
- install_exception_handler(EXCPTN_IRQ, ipi_handler);
+ install_exception_handler(EXCPTN_IRQ, handler);
#else
- install_irq_handler(EL1H_IRQ, ipi_handler);
+ install_irq_handler(EL1H_IRQ, handler);
#endif
local_irq_enable();
}
static void ipi_send(void)
{
- ipi_enable();
+ setup_irq(ipi_handler);
wait_on_ready();
ipi_test_self();
ipi_test_smp();
@@ -238,7 +238,7 @@ static void ipi_send(void)
static void ipi_recv(void)
{
- ipi_enable();
+ setup_irq(ipi_handler);
cpumask_set_cpu(smp_processor_id(), &ready);
while (1)
wfi();
@@ -295,14 +295,7 @@ static void ipi_clear_active_handler(struct pt_regs *regs
__unused)
static void run_active_clear_test(void)
{
report_prefix_push("active");
- gic_enable_defaults();
-#ifdef __arm__
- install_exception_handler(EXCPTN_IRQ, ipi_clear_active_handler);
-#else
- install_irq_handler(EL1H_IRQ, ipi_clear_active_handler);
-#endif
- local_irq_enable();
-
+ setup_irq(ipi_clear_active_handler);
ipi_test_self();
report_prefix_pop();
}
diff --git a/lib/arm/asm/processor.h b/lib/arm/asm/processor.h
index 1e1132d..e26ef89 100644
--- a/lib/arm/asm/processor.h
+++ b/lib/arm/asm/processor.h
@@ -26,7 +26,9 @@ enum vector {
EXCPTN_MAX,
};
+typedef void (*irq_handler_fn)(struct pt_regs *regs);
typedef void (*exception_fn)(struct pt_regs *);
+
extern void install_exception_handler(enum vector v, exception_fn fn);
extern void show_regs(struct pt_regs *regs);
--
2.20.1
- [kvm-unit-tests PATCH v7 00/13] arm/arm64: Add ITS tests, Eric Auger, 2020/03/20
- [kvm-unit-tests PATCH v7 01/13] libcflat: Add other size defines, Eric Auger, 2020/03/20
- [kvm-unit-tests PATCH v7 02/13] page_alloc: Introduce get_order(), Eric Auger, 2020/03/20
- [kvm-unit-tests PATCH v7 03/13] arm/arm64: gic: Introduce setup_irq() helper,
Eric Auger <=
- [kvm-unit-tests PATCH v7 04/13] arm/arm64: gicv3: Add some re-distributor defines, Eric Auger, 2020/03/20
- [kvm-unit-tests PATCH v7 05/13] arm/arm64: gicv3: Set the LPI config and pending tables, Eric Auger, 2020/03/20
- [kvm-unit-tests PATCH v7 06/13] arm/arm64: ITS: Introspection tests, Eric Auger, 2020/03/20
- Re: [kvm-unit-tests PATCH v7 06/13] arm/arm64: ITS: Introspection tests, Zenghui Yu, 2020/03/30
- Re: [kvm-unit-tests PATCH v7 06/13] arm/arm64: ITS: Introspection tests, Auger Eric, 2020/03/30
- Re: [kvm-unit-tests PATCH v7 06/13] arm/arm64: ITS: Introspection tests, Andrew Jones, 2020/03/30
- Re: [kvm-unit-tests PATCH v7 06/13] arm/arm64: ITS: Introspection tests, Auger Eric, 2020/03/30
- Re: [kvm-unit-tests PATCH v7 06/13] arm/arm64: ITS: Introspection tests, Andrew Jones, 2020/03/30
- Re: [kvm-unit-tests PATCH v7 06/13] arm/arm64: ITS: Introspection tests, Auger Eric, 2020/03/30
- Re: [kvm-unit-tests PATCH v7 06/13] arm/arm64: ITS: Introspection tests, Zenghui Yu, 2020/03/30