[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 0/3] Wire up USB controllers on fsl-imx6 and fsl-imx6ul
From: |
Peter Maydell |
Subject: |
Re: [PATCH 0/3] Wire up USB controllers on fsl-imx6 and fsl-imx6ul |
Date: |
Mon, 9 Mar 2020 17:09:21 +0000 |
On Sun, 1 Mar 2020 at 17:04, Guenter Roeck <address@hidden> wrote:
>
> This patch series wires up the USB controllers on fsl-imx6 and fsl-imx6ul
> emulations.
>
> The first patch is a prerequisite for the following patches. It provides
> a dummy implementation of a register widely used on i.MX systems, and
> specifically the reset behavior of this register. This is needed to make
> the USB ports operational without full implementation of an emulation
> of its PHY controller.
>
> ----------------------------------------------------------------
> Guenter Roeck (3):
> Add dummy i.MXS STMP register support
> arm: fsl-imx6ul: Wire up USB controllers
> hw/arm/fsl-imx6: Wire up USB controllers
I'm not a huge fan of the "dummy device that's really just
implementing 4 registers from the middle of some other
device" approach. Unless you think we're strongly likely
to want to use it in other places, I think I'd prefer
to just implement a (minimal/no-functionality) model of
the PHY register block.
thanks
-- PMM