[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 0/6] hw/arm/smmuv3: Correct stream ID and event address ha
From: |
Peter Maydell |
Subject: |
Re: [PATCH v3 0/6] hw/arm/smmuv3: Correct stream ID and event address handling |
Date: |
Tue, 17 Dec 2019 15:25:10 +0000 |
On Tue, 17 Dec 2019 at 10:04, Auger Eric <address@hidden> wrote:
>
> Hi,
>
> On 12/16/19 4:15 PM, Simon Veith wrote:
> > While working on the Linux SMMUv3 driver, I noticed a few cases where the
> > QEMU
> > SMMUv3 behavior relating to stream tables was inconsistent with our
> > hardware.
> >
> > Also, when debugging those differences, I found that the errors reported
> > through
> > the QEMU SMMUv3 event queue contained the address fields in an incorrect
> > position.
> >
> > These patches correct the QEMU SMMUv3 behavior to match the specification
> > (and
> > the behavior that I observed in our hardware). Linux guests normally will
> > not
> > notice these issues, but other SMMUv3 driver implementations might.
> >
> > Changes in v2:
> >
> > * New patch "hw/arm/smmuv3: Correct SMMU_BASE_ADDR_MASK value" added
> > * Updated patch "hw/arm/smmuv3: Check stream IDs against actual table
> > LOG2SIZE"
> > * Updated patch "hw/arm/smmuv3: Align stream table base address to table
> > size"
> >
> > Changes in v3:
> >
> > * No changes, but sending again to correct a patch submission mishap that
> > confused Patchew
> >
> > Simon Veith (6):
> > hw/arm/smmuv3: Apply address mask to linear strtab base address
> > hw/arm/smmuv3: Correct SMMU_BASE_ADDR_MASK value
> > hw/arm/smmuv3: Check stream IDs against actual table LOG2SIZE
> > hw/arm/smmuv3: Align stream table base address to table size
> > hw/arm/smmuv3: Use correct bit positions in EVT_SET_ADDR2 macro
> > hw/arm/smmuv3: Report F_STE_FETCH fault address in correct word
> > position
>
> The series looks good to me. Also tested against non regression.
>
> Tested-by: Eric Auger <address@hidden>
Applied to target-arm.next, thanks.
-- PMM
- [PATCH v3 2/6] hw/arm/smmuv3: Correct SMMU_BASE_ADDR_MASK value, (continued)
- [PATCH v3 2/6] hw/arm/smmuv3: Correct SMMU_BASE_ADDR_MASK value, Simon Veith, 2019/12/16
- [PATCH v3 3/6] hw/arm/smmuv3: Check stream IDs against actual table LOG2SIZE, Simon Veith, 2019/12/16
- [PATCH v3 1/6] hw/arm/smmuv3: Apply address mask to linear strtab base address, Simon Veith, 2019/12/16
- [PATCH v3 5/6] hw/arm/smmuv3: Use correct bit positions in EVT_SET_ADDR2 macro, Simon Veith, 2019/12/16
- [PATCH v3 4/6] hw/arm/smmuv3: Align stream table base address to table size, Simon Veith, 2019/12/16
- [PATCH v3 6/6] hw/arm/smmuv3: Report F_STE_FETCH fault address in correct word position, Simon Veith, 2019/12/16
- Re: [PATCH v3 0/6] hw/arm/smmuv3: Correct stream ID and event address handling, Auger Eric, 2019/12/17
- Re: [PATCH v3 0/6] hw/arm/smmuv3: Correct stream ID and event address handling,
Peter Maydell <=