[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] hw/timer/pl031: Add warning "do not use as model to implemen
From: |
Peter Maydell |
Subject: |
Re: [PATCH] hw/timer/pl031: Add warning "do not use as model to implement a RTC" |
Date: |
Tue, 24 Sep 2019 15:14:07 +0100 |
On Tue, 24 Sep 2019 at 15:12, Philippe Mathieu-Daudé <address@hidden> wrote:
>
> Peter said we should "not use the pl031 as a good model of how
> to do an RTC, it has some definite flaws."
> Add this information to the PL031 header for other developers.
Lots of our code is less than great. I'm not sure this
specific case really justifies blazoning it in a comment header
at the top of the file... (If you do want to put in a comment,
being more specific about exactly what the problems are would
be better.)
thanks
-- PMM