[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-arm] [PATCH 3/4] migration: ram: Switch to ram block writeback
From: |
Dr. David Alan Gilbert |
Subject: |
Re: [Qemu-arm] [PATCH 3/4] migration: ram: Switch to ram block writeback |
Date: |
Tue, 10 Sep 2019 11:26:01 +0100 |
User-agent: |
Mutt/1.12.1 (2019-06-15) |
* Beata Michalska (address@hidden) wrote:
> Switch to ram block writeback for pmem migration.
>
> Signed-off-by: Beata Michalska <address@hidden>
> ---
> migration/ram.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/migration/ram.c b/migration/ram.c
> index b01a37e7ca..8ea0bd63fc 100644
> --- a/migration/ram.c
> +++ b/migration/ram.c
> @@ -33,7 +33,6 @@
> #include "qemu/bitops.h"
> #include "qemu/bitmap.h"
> #include "qemu/main-loop.h"
> -#include "qemu/pmem.h"
> #include "xbzrle.h"
> #include "ram.h"
> #include "migration.h"
> @@ -4064,9 +4063,7 @@ static int ram_load_cleanup(void *opaque)
> RAMBlock *rb;
>
> RAMBLOCK_FOREACH_NOT_IGNORED(rb) {
> - if (ramblock_is_pmem(rb)) {
> - pmem_persist(rb->host, rb->used_length);
> - }
> + qemu_ram_block_writeback(rb);
ACK for migration
Although I do worry that if you really have pmem hardware, is it better
to fail the migration if you don't have libpmem available?
Dave
> }
>
> xbzrle_load_cleanup();
> --
> 2.17.1
>
--
Dr. David Alan Gilbert / address@hidden / Manchester, UK
- [Qemu-arm] [PATCH 0/4] target/arm: Support for Data Cache Clean up to PoP, Beata Michalska, 2019/09/10
- [Qemu-arm] [PATCH 3/4] migration: ram: Switch to ram block writeback, Beata Michalska, 2019/09/10
- Re: [Qemu-arm] [PATCH 3/4] migration: ram: Switch to ram block writeback,
Dr. David Alan Gilbert <=
- Re: [Qemu-arm] [PATCH 3/4] migration: ram: Switch to ram block writeback, Beata Michalska, 2019/09/10
- Re: [Qemu-arm] [PATCH 3/4] migration: ram: Switch to ram block writeback, Dr. David Alan Gilbert, 2019/09/10
- Re: [Qemu-arm] [PATCH 3/4] migration: ram: Switch to ram block writeback, Beata Michalska, 2019/09/10
- Re: [Qemu-arm] [PATCH 3/4] migration: ram: Switch to ram block writeback, Dr. David Alan Gilbert, 2019/09/11
- Re: [Qemu-arm] [PATCH 3/4] migration: ram: Switch to ram block writeback, Beata Michalska, 2019/09/12
Re: [Qemu-devel] [PATCH 3/4] migration: ram: Switch to ram block writeback, Richard Henderson, 2019/09/24
[Qemu-arm] [PATCH 4/4] target/arm: Add support for DC CVAP & DC CVADP ins, Beata Michalska, 2019/09/10