[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-arm] [Qemu-devel] [PATCH] hw/arm/virt: Add support for Cortex-
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [Qemu-arm] [Qemu-devel] [PATCH] hw/arm/virt: Add support for Cortex-A7 |
Date: |
Mon, 1 Jul 2019 11:36:06 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 |
On 6/30/19 5:13 PM, Jan Kiszka wrote:
> From: Jan Kiszka <address@hidden>
>
> No reason to deny this type.
Maybe add "As the A15, it supports the EL2/V7VE features."?
>
> Signed-off-by: Jan Kiszka <address@hidden>
> ---
> hw/arm/virt.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/hw/arm/virt.c b/hw/arm/virt.c
> index 431e2900fd..ed009fa447 100644
> --- a/hw/arm/virt.c
> +++ b/hw/arm/virt.c
> @@ -176,6 +176,7 @@ static const int a15irqmap[] = {
> };
>
> static const char *valid_cpus[] = {
> + ARM_CPU_TYPE_NAME("cortex-a7"),
> ARM_CPU_TYPE_NAME("cortex-a15"),
> ARM_CPU_TYPE_NAME("cortex-a53"),
> ARM_CPU_TYPE_NAME("cortex-a57"),
Should we list here all cpu with arm_feature(ARM_FEATURE_V7VE | V8)? or EL2?
> --
> 2.16.4
>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: [Qemu-arm] [Qemu-devel] [PATCH] hw/arm/virt: Add support for Cortex-A7,
Philippe Mathieu-Daudé <=