[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-arm] [PATCH 36/42] target/arm: Convert VFP round insns to deco
From: |
Richard Henderson |
Subject: |
Re: [Qemu-arm] [PATCH 36/42] target/arm: Convert VFP round insns to decodetree |
Date: |
Sat, 8 Jun 2019 14:11:51 -0500 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 |
On 6/6/19 12:46 PM, Peter Maydell wrote:
> Convert the VFP round-to-integer instructions VRINTR, VRINTZ and
> VRINTX to decodetree.
>
> These instructions were only introduced as part of the "VFP misc"
> additions in v8A, so we check this. The old decoder's implementation
> was incorrectly providing them even for v7A CPUs.
>
> Signed-off-by: Peter Maydell <address@hidden>
> ---
> target/arm/translate-vfp.inc.c | 163 +++++++++++++++++++++++++++++++++
> target/arm/translate.c | 45 +--------
> target/arm/vfp.decode | 15 +++
> 3 files changed, 179 insertions(+), 44 deletions(-)
Reviewed-by: Richard Henderson <address@hidden>
r~
- Re: [Qemu-arm] [PATCH 15/42] target/arm: Convert VFP VLDR and VSTR to decodetree, (continued)
- [Qemu-arm] [PATCH 25/42] target/arm: Convert VSUB to decodetree, Peter Maydell, 2019/06/06
- [Qemu-arm] [PATCH 32/42] target/arm: Convert VMOV (register) to decodetree, Peter Maydell, 2019/06/06
- [Qemu-arm] [PATCH 33/42] target/arm: Convert VFP comparison insns to decodetree, Peter Maydell, 2019/06/06
- [Qemu-arm] [PATCH 07/42] target/arm: Convert VMINNM, VMAXNM to decodetree, Peter Maydell, 2019/06/06
- [Qemu-arm] [PATCH 36/42] target/arm: Convert VFP round insns to decodetree, Peter Maydell, 2019/06/06
- Re: [Qemu-arm] [PATCH 36/42] target/arm: Convert VFP round insns to decodetree,
Richard Henderson <=
- [Qemu-arm] [PATCH 09/42] target/arm: Convert VCVTA/VCVTN/VCVTP/VCVTM to decodetree, Peter Maydell, 2019/06/06
- [Qemu-arm] [PATCH 05/42] target/arm: Explicitly enable VFP short-vectors for aarch32 -cpu max, Peter Maydell, 2019/06/06
- [Qemu-arm] [PATCH 39/42] target/arm: Convert VJCVT to decodetree, Peter Maydell, 2019/06/06
- [Qemu-arm] [PATCH 22/42] target/arm: Convert VMUL to decodetree, Peter Maydell, 2019/06/06
- [Qemu-arm] [PATCH 08/42] target/arm: Convert VRINTA/VRINTN/VRINTP/VRINTM to decodetree, Peter Maydell, 2019/06/06