[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-arm] [PATCH v2 27/28] tests/qemu-iotests: re-format output to
From: |
Max Reitz |
Subject: |
Re: [Qemu-arm] [PATCH v2 27/28] tests/qemu-iotests: re-format output to for make check-block |
Date: |
Mon, 27 May 2019 18:53:09 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 |
On 27.05.19 18:20, Alex Bennée wrote:
>
> Max Reitz <address@hidden> writes:
>
>> On 23.05.19 12:25, Alex Bennée wrote:
>>> This attempts to clean-up the output to better match the output of the
>>> rest of the QEMU check system when called with -makecheck. This includes:
>>>
>>> - formatting as " TEST iotest-FMT: nnn"
>>> - only dumping config on failure (when -makecheck enabled)
>>>
>>> The non-make check output has been cleaned up as well:
>>>
>>> - line re-displayed (\r) at the end
>>> - fancy colours for pass/fail/skip
>>> - timestamps always printed (option removed)
>>>
>>> Signed-off-by: Alex Bennée <address@hidden>
>>> Message-Id: <address@hidden>
>>> Tested-by: Thomas Huth <address@hidden>
>>>
>>> ---
>>> v3
>>> - revert echo to printf
>>> - add _report_test_start
>>> v4
>>> - -pretty -> -makecheck
>>> - keep all output together for makecheck
>>> v5
>>> - merged in kwolf's pretty printing
>>> - timestamps always printed in non-makecheck mode
>>> ---
>>> tests/qemu-iotests/check | 179 +++++++++++++++++++++++++--------------
>>> 1 file changed, 116 insertions(+), 63 deletions(-)
>>
>> Unless I missed something, this breaks ./check:
>>
>> $ ./check -T -qcow2
>> 000 - unknown test, ignored
>
> Because -T has been dropped (timestamps are always shown). Of course
> removing from the opts passing falls through. Should I just do:
Ah, OK.
> modified tests/qemu-iotests/check
> @@ -433,6 +433,11 @@ testlist options
> cachemode=true
> xpand=false
> ;;
> + -T)
> + echo "-T no longer needed"
> + exit -1
> + ;;
> +
> -v)
> verbose=true
Hm, why not just ignore it?
Max
signature.asc
Description: OpenPGP digital signature
- Re: [Qemu-arm] [Qemu-devel] [PATCH v2 03/28] semihosting: implement a semihosting console, (continued)
[Qemu-arm] [PATCH v2 15/28] tests/tcg/multiarch: add hello world system test, Alex Bennée, 2019/05/23
[Qemu-arm] [PATCH v2 17/28] tests/tcg/aarch64: add system boot.S, Alex Bennée, 2019/05/23
[Qemu-arm] [PATCH v2 18/28] tests/tcg/multiarch: move the system memory test, Alex Bennée, 2019/05/23
[Qemu-arm] [PATCH v2 27/28] tests/qemu-iotests: re-format output to for make check-block, Alex Bennée, 2019/05/23
[Qemu-arm] [PATCH v2 22/28] .travis.yml: enable aarch64-softmmu and alpha-softmmu tcg tests, Alex Bennée, 2019/05/23
[Qemu-arm] [PATCH v2 25/28] Makefile.target: support per-target coverage reports, Alex Bennée, 2019/05/23
[Qemu-arm] [PATCH v2 23/28] Makefile: fix coverage-report reference to BUILD_DIR, Alex Bennée, 2019/05/23
[Qemu-arm] [PATCH v2 28/28] tests: Run the iotests during "make check" again, Alex Bennée, 2019/05/23
[Qemu-arm] [PATCH v2 24/28] Makefile: include per-target build directories in coverage report, Alex Bennée, 2019/05/23
[Qemu-arm] [PATCH v2 21/28] tests/tcg/alpha: add system boot.S, Alex Bennée, 2019/05/23
[Qemu-arm] [PATCH v2 12/28] tests/docker: add ubuntu 18.04, Alex Bennée, 2019/05/23
[Qemu-arm] [PATCH v2 26/28] tests/qemu-iotests/group: Re-use the "auto" group for tests that can always run, Alex Bennée, 2019/05/23
[Qemu-arm] [PATCH v2 19/28] tests/tcg/minilib: support %c format char, Alex Bennée, 2019/05/23