[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-arm] [Qemu-devel] [PATCH 2/4] hw/arm/exynos4: Use the IEC bina
From: |
Alistair Francis |
Subject: |
Re: [Qemu-arm] [Qemu-devel] [PATCH 2/4] hw/arm/exynos4: Use the IEC binary prefix definitions |
Date: |
Mon, 20 May 2019 14:48:08 -0700 |
On Mon, May 20, 2019 at 2:48 PM Philippe Mathieu-Daudé
<address@hidden> wrote:
>
> It eases code review, unit is explicit.
>
> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
Reviewed-by: Alistair Francis <address@hidden>
Alistair
> ---
> hw/arm/exynos4_boards.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/hw/arm/exynos4_boards.c b/hw/arm/exynos4_boards.c
> index f0c24b7992e..f824eef0d36 100644
> --- a/hw/arm/exynos4_boards.c
> +++ b/hw/arm/exynos4_boards.c
> @@ -22,6 +22,7 @@
> */
>
> #include "qemu/osdep.h"
> +#include "qemu/units.h"
> #include "qapi/error.h"
> #include "qemu/error-report.h"
> #include "qemu-common.h"
> @@ -60,8 +61,8 @@ static int
> exynos4_board_smp_bootreg_addr[EXYNOS4_NUM_OF_BOARDS] = {
> };
>
> static unsigned long exynos4_board_ram_size[EXYNOS4_NUM_OF_BOARDS] = {
> - [EXYNOS4_BOARD_NURI] = 0x40000000,
> - [EXYNOS4_BOARD_SMDKC210] = 0x40000000,
> + [EXYNOS4_BOARD_NURI] = 1 * GiB,
> + [EXYNOS4_BOARD_SMDKC210] = 1 * GiB,
> };
>
> static struct arm_boot_info exynos4_board_binfo = {
> --
> 2.20.1
>
>
- [Qemu-arm] [PATCH 0/4] arm: exynos4: Add dma support for smdkc210, Philippe Mathieu-Daudé, 2019/05/20
- [Qemu-arm] [PATCH 1/4] hw/arm/exynos4: Remove unuseful debug code, Philippe Mathieu-Daudé, 2019/05/20
- [Qemu-arm] [PATCH 2/4] hw/arm/exynos4: Use the IEC binary prefix definitions, Philippe Mathieu-Daudé, 2019/05/20
- Re: [Qemu-arm] [Qemu-devel] [PATCH 2/4] hw/arm/exynos4: Use the IEC binary prefix definitions,
Alistair Francis <=
- [Qemu-arm] [PATCH 3/4] hw/arm/exynos4210: Add DMA support for the Exynos4210, Philippe Mathieu-Daudé, 2019/05/20
- [Qemu-arm] [PATCH 4/4] hw/arm/exynos4210: QOM'ify the Exynos4210 SoC, Philippe Mathieu-Daudé, 2019/05/20
- Re: [Qemu-arm] [PATCH 0/4] arm: exynos4: Add dma support for smdkc210, Peter Maydell, 2019/05/23