[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-arm] [Qemu-devel] [PATCH 3/5] hw/sd/sdhci: Don't leak memory r
From: |
Richard Henderson |
Subject: |
Re: [Qemu-arm] [Qemu-devel] [PATCH 3/5] hw/sd/sdhci: Don't leak memory region in sdhci_sysbus_realize() |
Date: |
Tue, 4 Dec 2018 07:58:54 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.3.1 |
On 12/4/18 7:29 AM, Peter Maydell wrote:
> In sdhci_sysbus_realize() we override the initialization of
> s->iomem that sdhci_common_realize() performs. However we
> don't destroy the old memory region before reinitializing
> it, which means that the memory allocated for mr->name in
> memory_region_do_init() is leaked.
>
> Since sdhci_initfn() already initializes s->io_ops to
> &sdhci_mmio_ops, always use that in sdhci_common_realize()
> and remove the now-unnecessary reinitialization of the
> MMIO region from sdhci_sysbus_realize().
>
> Spotted by clang's leak sanitizer.
>
> Signed-off-by: Peter Maydell <address@hidden>
> ---
> hw/sd/sdhci.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
Reviewed-by: Richard Henderson <address@hidden>
r~
- [Qemu-arm] [PATCH 0/5] arm: five simple memory leak fixes, Peter Maydell, 2018/12/04
- [Qemu-arm] [PATCH 4/5] tests/test-arm-mptimer: Don't leak string memory, Peter Maydell, 2018/12/04
- [Qemu-arm] [PATCH 5/5] target/arm: Create timers in realize, not init, Peter Maydell, 2018/12/04
- [Qemu-arm] [PATCH 2/5] hw/arm/mps2-tz.c: Free mscname string in make_dma(), Peter Maydell, 2018/12/04
- [Qemu-arm] [PATCH 3/5] hw/sd/sdhci: Don't leak memory region in sdhci_sysbus_realize(), Peter Maydell, 2018/12/04
- [Qemu-arm] [PATCH 1/5] target/arm: Free name string in ARMCPRegInfo hashtable entries, Peter Maydell, 2018/12/04