[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-arm] [Qemu-devel] [PATCH v5 18/24] hw: i386: Export the MADT b
From: |
Igor Mammedov |
Subject: |
Re: [Qemu-arm] [Qemu-devel] [PATCH v5 18/24] hw: i386: Export the MADT build method |
Date: |
Fri, 16 Nov 2018 10:27:35 +0100 |
On Mon, 5 Nov 2018 02:40:41 +0100
Samuel Ortiz <address@hidden> wrote:
> It is going to be used by the PC machine type as the MADT table builder
> method and thus needs to be exported outside of acpi-build.c
>
> Also, now that the generic build_madt() API is exported, we have to
> rename the ARM static one in order to avoid build time conflicts.
>
> Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
> Tested-by: Philippe Mathieu-Daudé <address@hidden>
> Signed-off-by: Samuel Ortiz <address@hidden>
> ---
> include/hw/i386/acpi.h | 28 ++++++++++++++++++++++++++++
> hw/arm/virt-acpi-build.c | 4 ++--
> hw/i386/acpi-build.c | 4 ++--
> 3 files changed, 32 insertions(+), 4 deletions(-)
> create mode 100644 include/hw/i386/acpi.h
>
> diff --git a/include/hw/i386/acpi.h b/include/hw/i386/acpi.h
> new file mode 100644
> index 0000000000..b7a887111d
> --- /dev/null
> +++ b/include/hw/i386/acpi.h
[...]
> +/* ACPI MADT (Multiple APIC Description Table) build method */
> +void build_madt(GArray *table_data, BIOSLinker *linker,
> + MachineState *ms, AcpiConfiguration *conf);
> +
> +#endif
> diff --git a/hw/arm/virt-acpi-build.c b/hw/arm/virt-acpi-build.c
> index b5e165543a..b0354c5f03 100644
> --- a/hw/arm/virt-acpi-build.c
> +++ b/hw/arm/virt-acpi-build.c
> @@ -564,7 +564,7 @@ build_gtdt(GArray *table_data, BIOSLinker *linker,
> VirtMachineState *vms)
>
> /* MADT */
> static void
> -build_madt(GArray *table_data, BIOSLinker *linker, VirtMachineState *vms)
> +virt_build_madt(GArray *table_data, BIOSLinker *linker, VirtMachineState
> *vms)
> {
You are moving build_madt() into x86 specific header i386/acpi.h
so question is why do you touch ARM variant at all?
[...]
- [Qemu-arm] [PATCH v5 16/24] hw: acpi: Fix memory hotplug AML generation error, (continued)
- [Qemu-arm] [PATCH v5 17/24] hw: acpi: Export the PCI hotplug API, Samuel Ortiz, 2018/11/04
- [Qemu-arm] [PATCH v5 18/24] hw: i386: Export the MADT build method, Samuel Ortiz, 2018/11/04
- Re: [Qemu-arm] [Qemu-devel] [PATCH v5 18/24] hw: i386: Export the MADT build method,
Igor Mammedov <=
- [Qemu-arm] [PATCH v5 19/24] hw: acpi: Retrieve the PCI bus from AcpiPciHpState, Samuel Ortiz, 2018/11/04
- Re: [Qemu-arm] [PATCH v5 19/24] hw: acpi: Retrieve the PCI bus from AcpiPciHpState, Igor Mammedov, 2018/11/16
- Re: [Qemu-arm] [PATCH v5 19/24] hw: acpi: Retrieve the PCI bus from AcpiPciHpState, Boeuf, Sebastien, 2018/11/16
- Re: [Qemu-arm] [PATCH v5 19/24] hw: acpi: Retrieve the PCI bus from AcpiPciHpState, Igor Mammedov, 2018/11/19
- Re: [Qemu-arm] [PATCH v5 19/24] hw: acpi: Retrieve the PCI bus from AcpiPciHpState, Boeuf, Sebastien, 2018/11/19
- Re: [Qemu-arm] [PATCH v5 19/24] hw: acpi: Retrieve the PCI bus from AcpiPciHpState, Igor Mammedov, 2018/11/20
[Qemu-arm] [PATCH v5 21/24] hw: i386: Implement the ACPI builder interface for PC, Samuel Ortiz, 2018/11/04
[Qemu-arm] [PATCH v5 20/24] hw: acpi: Define ACPI tables builder interface, Samuel Ortiz, 2018/11/04