[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-arm] [PATCH v5 09/24] hw: i386: Move PCI host definitions to p
From: |
Igor Mammedov |
Subject: |
Re: [Qemu-arm] [PATCH v5 09/24] hw: i386: Move PCI host definitions to pci_host.h |
Date: |
Fri, 9 Nov 2018 15:30:48 +0100 |
On Mon, 5 Nov 2018 02:40:32 +0100
Samuel Ortiz <address@hidden> wrote:
> The PCI hole properties are not pc or i386 specific. They belong to the
> PCI host header instead.
>
> Signed-off-by: Samuel Ortiz <address@hidden>
> ---
> include/hw/i386/pc.h | 5 -----
> include/hw/pci/pci_host.h | 6 ++++++
> 2 files changed, 6 insertions(+), 5 deletions(-)
>
> diff --git a/include/hw/i386/pc.h b/include/hw/i386/pc.h
> index fed136fcdd..bbbdb33ea3 100644
> --- a/include/hw/i386/pc.h
> +++ b/include/hw/i386/pc.h
> @@ -182,11 +182,6 @@ void pc_acpi_init(const char *default_dsdt);
>
> void pc_guest_info_init(PCMachineState *pcms);
>
> -#define PCI_HOST_PROP_PCI_HOLE_START "pci-hole-start"
> -#define PCI_HOST_PROP_PCI_HOLE_END "pci-hole-end"
> -#define PCI_HOST_PROP_PCI_HOLE64_START "pci-hole64-start"
> -#define PCI_HOST_PROP_PCI_HOLE64_END "pci-hole64-end"
> -#define PCI_HOST_PROP_PCI_HOLE64_SIZE "pci-hole64-size"
> #define PCI_HOST_BELOW_4G_MEM_SIZE "below-4g-mem-size"
> #define PCI_HOST_ABOVE_4G_MEM_SIZE "above-4g-mem-size"
>
> diff --git a/include/hw/pci/pci_host.h b/include/hw/pci/pci_host.h
> index ba31595fc7..e343f4d9ca 100644
> --- a/include/hw/pci/pci_host.h
> +++ b/include/hw/pci/pci_host.h
> @@ -38,6 +38,12 @@
> #define PCI_HOST_BRIDGE_GET_CLASS(obj) \
> OBJECT_GET_CLASS(PCIHostBridgeClass, (obj), TYPE_PCI_HOST_BRIDGE)
>
> +#define PCI_HOST_PROP_PCI_HOLE_START "pci-hole-start"
> +#define PCI_HOST_PROP_PCI_HOLE_END "pci-hole-end"
> +#define PCI_HOST_PROP_PCI_HOLE64_START "pci-hole64-start"
> +#define PCI_HOST_PROP_PCI_HOLE64_END "pci-hole64-end"
> +#define PCI_HOST_PROP_PCI_HOLE64_SIZE "pci-hole64-size"
these are pc/q53 machine specific properties and do not belong here
> +
> struct PCIHostState {
> SysBusDevice busdev;
>
- Re: [Qemu-arm] [PATCH v5 05/24] hw: acpi: Implement XSDT support for RSDP, (continued)
[Qemu-arm] [PATCH v5 06/24] hw: acpi: Factorize the RSDP build API implementation, Samuel Ortiz, 2018/11/04
[Qemu-arm] [PATCH v5 07/24] hw: acpi: Generalize AML build routines, Samuel Ortiz, 2018/11/04
[Qemu-arm] [PATCH v5 08/24] hw: acpi: Factorize _OSC AML across architectures, Samuel Ortiz, 2018/11/04
[Qemu-arm] [PATCH v5 09/24] hw: i386: Move PCI host definitions to pci_host.h, Samuel Ortiz, 2018/11/04
- Re: [Qemu-arm] [PATCH v5 09/24] hw: i386: Move PCI host definitions to pci_host.h,
Igor Mammedov <=
[Qemu-arm] [PATCH v5 10/24] hw: acpi: Export the PCI host and holes getters, Samuel Ortiz, 2018/11/04
[Qemu-arm] [PATCH v5 12/24] hw: acpi: Export the MCFG getter, Samuel Ortiz, 2018/11/04
[Qemu-arm] [PATCH v5 11/24] hw: acpi: Export and generalize the PCI host AML API, Samuel Ortiz, 2018/11/04