[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-arm] [PATCH v1 06/12] net: cadence_gem: Add support for select
From: |
Edgar E. Iglesias |
Subject: |
Re: [Qemu-arm] [PATCH v1 06/12] net: cadence_gem: Add support for selecting the DMA MemoryRegion |
Date: |
Mon, 8 Oct 2018 21:54:02 +0200 |
User-agent: |
Mutt/1.9.4 (2018-02-28) |
On Mon, Oct 08, 2018 at 01:24:51PM +0100, Peter Maydell wrote:
> On 3 October 2018 at 16:07, Edgar E. Iglesias <address@hidden> wrote:
> > From: "Edgar E. Iglesias" <address@hidden>
> >
> > Add support for selecting the Memory Region that the GEM
> > will do DMA to.
> >
> > Signed-off-by: Edgar E. Iglesias <address@hidden>
> > ---
>
>
> > @@ -1500,6 +1506,13 @@ static void gem_realize(DeviceState *dev, Error
> > **errp)
> > CadenceGEMState *s = CADENCE_GEM(dev);
> > int i;
> >
> > + if (s->dma_mr) {
> > + s->dma_as = g_malloc0(sizeof(AddressSpace));
> > + address_space_init(s->dma_as, s->dma_mr, NULL);
>
> Why not just have the CadenceGEMState embed the AddressSpace
>
> AddressSpace dma_as;
>
> rather than doing a separate memory allocation here?
No reason not to, I copied this from a pattern in our code and didn't reflect
too much about the allocation.
I'll change it for next version.
Cheers,
Edgar
>
> > + } else {
> > + s->dma_as = &address_space_memory;
> > + }
>
> thanks
> -- PMM
- [Qemu-arm] [PATCH v1 04/12] net: cadence_gem: Add macro with max number of descriptor words, (continued)
- [Qemu-arm] [PATCH v1 04/12] net: cadence_gem: Add macro with max number of descriptor words, Edgar E. Iglesias, 2018/10/03
- [Qemu-arm] [PATCH v1 05/12] net: cadence_gem: Add support for extended descriptors, Edgar E. Iglesias, 2018/10/03
- [Qemu-arm] [PATCH v1 06/12] net: cadence_gem: Add support for selecting the DMA MemoryRegion, Edgar E. Iglesias, 2018/10/03
- [Qemu-arm] [PATCH v1 07/12] net: cadence_gem: Implement support for 64bit descriptor addresses, Edgar E. Iglesias, 2018/10/03
- [Qemu-arm] [PATCH v1 08/12] net: cadence_gem: Announce 64bit addressing support, Edgar E. Iglesias, 2018/10/03
- [Qemu-arm] [PATCH v1 09/12] target-arm: powerctl: Enable HVC when starting CPUs to EL2, Edgar E. Iglesias, 2018/10/03
- [Qemu-arm] [PATCH v1 10/12] target/arm: Add the Cortex-A72, Edgar E. Iglesias, 2018/10/03