[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-arm] [PULL 3/8] usb/dev-mtp: Fix use of uninitialized values
From: |
Gerd Hoffmann |
Subject: |
[Qemu-arm] [PULL 3/8] usb/dev-mtp: Fix use of uninitialized values |
Date: |
Tue, 12 Jun 2018 12:44:25 +0200 |
From: Philippe Mathieu-Daudé <address@hidden>
This fixes:
hw/usb/dev-mtp.c:971:5: warning: 4th function call argument is an
uninitialized value
trace_usb_mtp_op_get_partial_object(s->dev.addr, o->handle, o->path,
c->argv[1], c->argv[2]);
^~~~~~~~~~
and:
hw/usb/dev-mtp.c:981:12: warning: Assigned value is garbage or undefined
offset = c->argv[1];
^ ~~~~~~~~~~
Reported-by: Clang Static Analyzer
Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
Message-id: address@hidden
Signed-off-by: Gerd Hoffmann <address@hidden>
---
hw/usb/dev-mtp.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/hw/usb/dev-mtp.c b/hw/usb/dev-mtp.c
index 560c61c7c1..b0ab6a7912 100644
--- a/hw/usb/dev-mtp.c
+++ b/hw/usb/dev-mtp.c
@@ -1017,12 +1017,16 @@ static MTPData *usb_mtp_get_object(MTPState *s,
MTPControl *c,
static MTPData *usb_mtp_get_partial_object(MTPState *s, MTPControl *c,
MTPObject *o)
{
- MTPData *d = usb_mtp_data_alloc(c);
+ MTPData *d;
off_t offset;
+ if (c->argc <= 2) {
+ return NULL;
+ }
trace_usb_mtp_op_get_partial_object(s->dev.addr, o->handle, o->path,
c->argv[1], c->argv[2]);
+ d = usb_mtp_data_alloc(c);
d->fd = open(o->path, O_RDONLY);
if (d->fd == -1) {
usb_mtp_data_free(d);
--
2.9.3
- [Qemu-arm] [PULL 0/8] Usb 20180612 patches, Gerd Hoffmann, 2018/06/12
- [Qemu-arm] [PULL 7/8] usb-hcd-xhci-test: add a test for ccid hotplug, Gerd Hoffmann, 2018/06/12
- [Qemu-arm] [PULL 8/8] usb-mtp: Return error on suspicious TYPE_DATA packet from initiator, Gerd Hoffmann, 2018/06/12
- [Qemu-arm] [PULL 6/8] usb-ccid: fix bus leak, Gerd Hoffmann, 2018/06/12
- [Qemu-arm] [PULL 1/8] usb: update docs, Gerd Hoffmann, 2018/06/12
- [Qemu-arm] [PULL 2/8] usb: correctly handle Zero Length Packets, Gerd Hoffmann, 2018/06/12
- [Qemu-arm] [PULL 3/8] usb/dev-mtp: Fix use of uninitialized values,
Gerd Hoffmann <=
- [Qemu-arm] [PULL 4/8] bus: do not unref the added child bus on realize, Gerd Hoffmann, 2018/06/12
- [Qemu-arm] [PULL 5/8] object: fix OBJ_PROP_LINK_UNREF_ON_RELEASE ambivalence, Gerd Hoffmann, 2018/06/12
- Re: [Qemu-arm] [PULL 0/8] Usb 20180612 patches, Peter Maydell, 2018/06/12