[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-arm] [Qemu-devel] [PATCH v2 1/2] arm_gicv3_kvm: increase clrof
From: |
Auger Eric |
Subject: |
Re: [Qemu-arm] [Qemu-devel] [PATCH v2 1/2] arm_gicv3_kvm: increase clroffset accordingly |
Date: |
Tue, 20 Mar 2018 09:07:39 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 |
Hi Shannon,
On 20/03/18 08:26, Shannon Zhao wrote:
> It forgot to increase clroffset during the loop. So it only clear the
> first 4 bytes.
Fixes 367b9f527becdd20ddf116e17a3c0c2bbc486920
("hw/intc/arm_gicv3_kvm: Implement get/put functions")
>
> Signed-off-by: Shannon Zhao <address@hidden>
Reviewed-by: Eric Auger <address@hidden>
Nice catch!
Thanks
Eric
> ---
> hw/intc/arm_gicv3_kvm.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/hw/intc/arm_gicv3_kvm.c b/hw/intc/arm_gicv3_kvm.c
> index ec37177..3536795 100644
> --- a/hw/intc/arm_gicv3_kvm.c
> +++ b/hw/intc/arm_gicv3_kvm.c
> @@ -243,6 +243,7 @@ static void kvm_dist_putbmp(GICv3State *s, uint32_t
> offset,
> if (clroffset != 0) {
> reg = 0;
> kvm_gicd_access(s, clroffset, ®, true);
> + clroffset += 4;
> }
> reg = *gic_bmp_ptr32(bmp, irq);
> kvm_gicd_access(s, offset, ®, true);
>
- [Qemu-arm] [PATCH v2 0/2] two fixes for KVM GICv3 dist get/put functions, Shannon Zhao, 2018/03/20
- [Qemu-arm] [PATCH v2 1/2] arm_gicv3_kvm: increase clroffset accordingly, Shannon Zhao, 2018/03/20
- Re: [Qemu-arm] [Qemu-devel] [PATCH v2 1/2] arm_gicv3_kvm: increase clroffset accordingly,
Auger Eric <=
- [Qemu-arm] [PATCH v2 2/2] arm_gicv3_kvm: kvm_dist_get/put: skip the registers banked by GICR, Shannon Zhao, 2018/03/20
- Re: [Qemu-arm] [Qemu-devel] [PATCH v2 2/2] arm_gicv3_kvm: kvm_dist_get/put: skip the registers banked by GICR, Auger Eric, 2018/03/20
- Re: [Qemu-arm] [PATCH v2 2/2] arm_gicv3_kvm: kvm_dist_get/put: skip the registers banked by GICR, Peter Maydell, 2018/03/20
- Re: [Qemu-arm] [PATCH v2 2/2] arm_gicv3_kvm: kvm_dist_get/put: skip the registers banked by GICR, Shannon Zhao, 2018/03/20
- Re: [Qemu-arm] [PATCH v2 2/2] arm_gicv3_kvm: kvm_dist_get/put: skip the registers banked by GICR, Peter Maydell, 2018/03/20
- Re: [Qemu-arm] [PATCH v2 2/2] arm_gicv3_kvm: kvm_dist_get/put: skip the registers banked by GICR, Shannon Zhao, 2018/03/21
- Re: [Qemu-arm] [PATCH v2 2/2] arm_gicv3_kvm: kvm_dist_get/put: skip the registers banked by GICR, Peter Maydell, 2018/03/23
- Re: [Qemu-arm] [PATCH v2 2/2] arm_gicv3_kvm: kvm_dist_get/put: skip the registers banked by GICR, Peter Maydell, 2018/03/29
- Re: [Qemu-arm] [PATCH v2 2/2] arm_gicv3_kvm: kvm_dist_get/put: skip the registers banked by GICR, Dr. David Alan Gilbert, 2018/03/29