[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-arm] [PATCH 2/2] bcm2835: add bcm2835_sdhost to bcm2835 platfo
From: |
Andrew Baumann |
Subject: |
Re: [Qemu-arm] [PATCH 2/2] bcm2835: add bcm2835_sdhost to bcm2835 platform |
Date: |
Tue, 21 Feb 2017 18:59:06 +0000 |
Hi Clement,
I think Peter already gave you a great high-level suggestion, but FWIW I
spotted one minor niggle here:
> diff --git a/hw/sd/Makefile.objs b/hw/sd/Makefile.objs
> index 31c83308f2..c2b7664264 100644
> --- a/hw/sd/Makefile.objs
> +++ b/hw/sd/Makefile.objs
> @@ -6,3 +6,4 @@ common-obj-$(CONFIG_SDHCI) += sdhci.o
> obj-$(CONFIG_MILKYMIST) += milkymist-memcard.o
> obj-$(CONFIG_OMAP) += omap_mmc.o
> obj-$(CONFIG_PXA2XX) += pxa2xx_mmci.o
> +obj-$(CONFIG_RASPI) += bcm2835_sdhost.o
I think the Makefile addition should be part of the other patch (1/2) in the
series.
Andrew