[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-arm] [Qemu-devel] [kvm-unit-tests PATCH v7 11/11] arm/arm64: g
From: |
Auger Eric |
Subject: |
Re: [Qemu-arm] [Qemu-devel] [kvm-unit-tests PATCH v7 11/11] arm/arm64: gic: don't just use zero |
Date: |
Thu, 24 Nov 2016 18:31:35 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 |
Hi Drew,
On 24/11/2016 15:11, Andrew Jones wrote:
> On Thu, Nov 24, 2016 at 10:57:01AM +0100, Auger Eric wrote:
>> Hi,
>>
>> On 23/11/2016 17:54, Andrew Jones wrote:
>>> Allow user to select who sends ipis and with which irq,
>>> rather than just always sending irq=0 from cpu0.
>>>
>>> Signed-off-by: Andrew Jones <address@hidden>
>>
>> Reviewed-by: Eric Auger <address@hidden>
>> Tested-by: Eric Auger <address@hidden>
>
> Thanks!
>
> But if I spin a v8 then I may just dump all the command line parsing
> stuff, dropping the optional input arguments sender and irq, or at
> least irq. I'm feeling it's a bit crufty... Any thoughts on that?
Hum personally I don' have sufficient experience on this test suite to
advise. Maybe let's get inspired of the kind of tests written on x86 and
their kind of command lines. Anyway I don't want to further slow down
the pull. We will be able to refine later on when adding new tests.
Thanks
Eric
>
> drew
>
- [Qemu-arm] [kvm-unit-tests PATCH v7 04/11] arm/arm64: add some delay routines, (continued)
- [Qemu-arm] [kvm-unit-tests PATCH v7 04/11] arm/arm64: add some delay routines, Andrew Jones, 2016/11/23
- [Qemu-arm] [kvm-unit-tests PATCH v7 07/11] arm/arm64: gicv2: add an IPI test, Andrew Jones, 2016/11/23
- [Qemu-arm] [kvm-unit-tests PATCH v7 05/11] arm/arm64: irq enable/disable, Andrew Jones, 2016/11/23
- [Qemu-arm] [kvm-unit-tests PATCH v7 08/11] libcflat: add IS_ALIGNED() macro, and page sizes, Andrew Jones, 2016/11/23
- [Qemu-arm] [kvm-unit-tests PATCH v7 09/11] arm/arm64: add initial gicv3 support, Andrew Jones, 2016/11/23
- [Qemu-arm] [kvm-unit-tests PATCH v7 11/11] arm/arm64: gic: don't just use zero, Andrew Jones, 2016/11/23
- [Qemu-arm] [kvm-unit-tests PATCH v7 10/11] arm/arm64: gicv3: add an IPI test, Andrew Jones, 2016/11/23