[Pingus-CVS] [bug #30022] SConscript broken using with_linuxevdev=0

[anonymous]

URL:
  <http://savannah.nongnu.org/bugs/?30022>

                 Summary: SConscript broken using with_linuxevdev=0
                 Project: Pingus
            Submitted by: None
            Submitted on: Tue 01 Jun 2010 03:49:09 AM UTC
                Category: General Stuff
                Severity: 3 - Normal
              Item Group: Installation Problem
                  Status: None
                 Privacy: Public
             Assigned to: None
             Open/Closed: Open
         Discussion Lock: Any
                 Release: SVN
        Operating System: All
         Planned Release: None

    _______________________________________________________

Details:

SConscript has two problems with building without evdev support:

1) reports += "  * Linux evdev support: disabled\n" # should be self.reports

2) Scons still attempts to build the tests for evdev, even if evdev support
is disabled; this fails on NetBSD (and other systems, I imagine) even though
the pingus still otherwise works.

SConscript.patch fixes the first problem.

The second problem can be changed by changing (line 343)

    for filename in Glob("test/*_test.cpp", strings=True):
        self.env.Program(filename[:-4], [filename, libpingus])

to something like

    for filename in Glob("test/*_test.cpp", strings=True):
        if(self.config_h_defines != ('HAVE_LINUXEVDEV', 1) and filename !=
'test/evdev_device_test.cpp)
            self.env.Program(filename[:-4], [filename, libpingus])

but I do not understand Python and scons enough to know exactly what. (I just
commented out those two lines.)



    _______________________________________________________

File Attachments:


-------------------------------------------------------
Date: Tue 01 Jun 2010 03:49:09 AM UTC  Name: SConscript.patch  Size: 520B  
By: None

<http://savannah.nongnu.org/bugs/download.php?file_id=20669>

    _______________________________________________________

Reply to this item at:

  <http://savannah.nongnu.org/bugs/?30022>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.nongnu.org/