[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Octave-patch-tracker] [patch #9360] image package: new function otsuthr
From: |
Carnë Draug |
Subject: |
[Octave-patch-tracker] [patch #9360] image package: new function otsuthresh.m |
Date: |
Sat, 1 Dec 2018 13:34:33 -0500 (EST) |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Firefox/60.0 |
Follow-up Comment #12, patch #9360 (project octave):
Other than Hartmut comments, looks fine to me. Small nitpick. Instead of
checking for Inf, NaN, and < 0 (and forgetting NA), you can just do:
! all (hist >= 0 | hist < Inf)
Also, are we just checking for sparse because Matlab does not support it? I
think we lose nothing by letting it pass. What do we care if an histogram is
internally stored as a sparse array?
_______________________________________________________
Reply to this item at:
<https://savannah.gnu.org/patch/?9360>
_______________________________________________
Message sent via Savannah
https://savannah.gnu.org/
- [Octave-patch-tracker] [patch #9360] image package: new function otsuthresh.m,
Carnë Draug <=