[Octave-bug-tracker] [bug #65529] (signal) should include <cassert>

[Dmitri A. Sergatskov]

URL:
  <https://savannah.gnu.org/bugs/?65529>

                 Summary: (signal) should include <cassert>
                   Group: GNU Octave
               Submitter: dasergatskov
               Submitted: Thu 28 Mar 2024 07:31:34 PM UTC
                Category: Octave Package
                Severity: 3 - Normal
                Priority: 5 - Normal
              Item Group: None
                  Status: None
             Assigned to: None
         Originator Name: 
        Originator Email: 
             Open/Closed: Open
                 Release: dev
         Discussion Lock: Any
        Operating System: Any
           Fixed Release: None
         Planned Release: None


    _______________________________________________________

Follow-up Comments:


-------------------------------------------------------
Date: Thu 28 Mar 2024 07:31:34 PM UTC By: Dmitri A. Sergatskov <dasergatskov>
On a recent Octave 10 (dev), compilation fails:

g++ -std=gnu++17 -c  -fPIC -I/usr/local/include/octave-10.0.0/octave/..
-I/usr/local/include/octave-10.0.0/octave -I/usr/local/include  -pthread
-fopenmp -ggdb3 -O2 -march=native -mtune=native -mavx -mavx2 -flto=auto  -Wall
  upfirdn.cc -o /tmp/oct-bDEog8.o
remez.cc: In function ‘int Search(int, int*, int, double*)’:
remez.cc:389:3: error: ‘assert’ was not declared in this scope
  389 |   assert(extra >= 0);
      |   ^~~~~~
remez.cc:40:1: note: ‘assert’ is defined in header ‘<cassert>’; did
you forget to ‘#include <cassert>’?
   39 | #include "octave-compat.h"
  +++ |+#include <cassert>
   40 | 
remez.cc: In function ‘int remez(double*, int, int, const double*, const
double*, const double*, int, int)’:
remez.cc:704:29: error: ‘assert’ was not declared in this scope
  704 |       for(i=0; i <= r; i++) assert(Ext[i]<gridsize);
      |                             ^~~~~~
remez.cc:704:29: note: ‘assert’ is defined in header ‘<cassert>’; did
you forget to ‘#include <cassert>’?
make: *** [Makefile:48: remez.oct] Error 1


mxe-octave patch that makes it compile is here:

https://hg.octave.org/mxe-octave/rev/51670dbb688f

Discussion is here:

https://octave.discourse.group/t/assert-panic-error-and-ndebug/5409/18

Dmitri.
-- 








    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/bugs/?65529>

_______________________________________________
Message sent via Savannah
https://savannah.gnu.org/